Here is a draft that participants in this thread can review: [1] [1] https://github.com/apache/incubator-streampark/pull/3689
Best, tison. tison <wander4...@gmail.com> 于2024年4月29日周一 16:01写道： > > So a condition of including MIT licensed code is to include the > relevant MIT license text. > > Confirmed this is the case. > > I found the mention to vue-vben-admin is licensed under MIT at [1] but I > don't find the LICENSE of vue-vben-admin bundled also. > > I agree that the LICENSE file at [2] seems to be misleading and since > those MIT licensed files doesn't have a license header, it would be better > to update the LICENSE content at the root path of streampark-console-webapp. > > [1] > https://github.com/apache/incubator-streampark/blob/fe536ef7e24db2adeaaa298e1e8933899b61f834/LICENSE#L223-L251 > [2] streampark-console/streampark-console-webapp/LICENSE > > The license issue of vue-vben-admin was pointed out at previous releases > [3]. It seems StreamPark still has some issues to resolve. > > [3] https://lists.apache.org/thread/p1f9k83q3tvz2pykfmjvpcsnxl8x4wl3 > > For using SCANOSS, Shawn Yang shares a video that you may leverage from > [4]. > > [4] https://lists.apache.org/thread/13s0cgfd6b5m7qtkcffz1rk1jbywy3wv > > Best, > tison. > > > Justin Mclean <jus...@classsoftware.com> 于2024年4月29日周一 15:32写道： > >> Hi, >> >> -1 (binding) from me >> >> I checked: >> - incubating in name >> - signatures and hashes correct >> - disclaimer exists >> - LICENSE is missing some info on the MIT license >> - NOTICE looks fine >> - I didn't compile from source >> >> So a condition of including MIT licensed code is to include the relevant >> MIT license text. That seems to be missing for for vue-vben-admin , as I >> can’t find it anywhere in the release. Oddly, the license file here [1] is >> an Apache one, not an MIT one, and it also fails to mention the MIT code >> under it. >> >> It looks like additional third-party code might also be in the release, >> but it is difficult to tell. I think you should run SCANOSS ( >> https://www.softwaretransparency.org/download) on your release and look >> into its results. >> >> Kind Regards, >> Justin >> >> >> 1. streampark-console/streampark-console-webapp/LICENSE >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >>
