+1 binding Checked sigs and sums: Matched LICENSE and NOTICE: Looks fine DISCLAIMER: In place Built from src: I pulled the docker image 'eclipse-temurin-focal-11.0.21_9_1.9.8_3.3.1' and then type sbt, passed Run tests: I just typed test in the sbt shell but it failed with 'Cannot connect to localhost:5432', seems we need to start some external services while running tests but I did not find any related documentation about how to test
Thanks. PJ Fanning <fannin...@apache.org> 于2023年12月27日周三 18:04写道： > > Would any of the Pekko mentors or indeed, any Incubator PMC members have time > to review this Pekko RC? It marks the final set of Pekko modules that have > yet to be released. > > On 2023/12/20 23:10:25 Matthew de Detrich wrote: > > Carrying over my +1 vote from > > https://lists.apache.org/thread/yyhoygwhox5yzrxy716kjmy7gcd4hm1r > > > > On Tue, Dec 19, 2023 at 7:16 PM PJ Fanning <fannin...@apache.org> wrote: > > > > > Hello Incubator Community, > > > > > > This is a call for a vote to release Apache Pekko(incubating) > > > Persistence R2DBC version 1.0.0-RC1. > > > > > > The Pekko vote result: > > > https://lists.apache.org/thread/w06swd1nd5jphtlronffw4jw18orn4hy > > > > > > Pekko Vote Thread > > > https://lists.apache.org/thread/k9xn5gyldpq0dypdo7cxgjjxkc04xtco > > > > > > The discussion thread: > > > https://lists.apache.org/thread/108tfnxofmp5bvq9y60pmwn34d6bs5s6 > > > > > > The release candidate: > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/pekko/PERSISTENCE-R2DBC-1.0.0-RC1/ > > > > > > This release has been signed with a PGP key, available here: > > > > > > https://dist.apache.org/repos/dist/release/incubator/pekko/KEYS > > > > > > Git branch for the release: > > > > > > https://github.com/apache/incubator-pekko-persistence-r2dbc/tree/v1.0.0-RC1 > > > Git commit ID: 3fc28f10a4570c9834495fef1d104a2dbd07fb44 > > > > > > Please download, verify, and test. > > > > > > We have also staged jars in the Apache Nexus Repository. These were > > > built with the same code > > > as appears in this Source Release Candidate. We would appreciate if > > > users could test with these too. > > > If anyone finds any serious problems with these jars, please also > > > notify us on this thread. > > > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > > > In sbt, you can add this resolver. > > > > > > resolvers += "Apache Pekko Staging" at > > > "https://repository.apache.org/content/groups/staging"; > > > > > > > > > The vote will be left open for at least 72 hours. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > To learn more about Apache Pekko, please see https://pekko.apache.org/ > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > [ ] Checksums and signatures. > > > [ ] LICENSE/NOTICE files exist > > > [ ] No unexpected binary files > > > [ ] Source files have ASF headers > > > [ ] Can compile from source > > > > > > To compile from the source, please refer to: > > > > > > > > > https://github.com/apache/incubator-pekko/blob/main/README.md#building-from-source > > > > > > Some of the tests rely on postgresql running locally on port 5432 and > > > the DDL is at ddl-scripts/create_tables_postgres.sql > > > > > > Some notes about verifying downloads can be found at: > > > > > > https://pekko.apache.org/download.html#verifying-downloads > > > > > > > > > Here is my +1 (binding). > > > > > > Thanks, > > > > > > PJ Fanning > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Alexanderufer 3-7, 10117 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
