+1 (binding)
[X] Download links are valid.
[X] Checksums and signatures.
[X] LICENSE/NOTICE files exist
I did notice "Copyright 2016 AddThis" in the LICENSE file wrt
MurmurHash3, something to fix for the next release?
Given the accompanying explanation in the file, I don't see this
as a showstopper for this release.
[X] No unexpected binary files
I didn't do an exhaustive check
[X] Source files have ASF headers
[-] Can compile from source
I ran "sbt compile" and "sbt package" but both had errors. A sample:
[error] bnd: Invalid value for Bundle-Version, HEAD+20231129-0950
does not match [0-9]{1,9}(\.[0-9]{1,9}(\.[0-9]{1,9}(\.[0-9A-Za-z_-]+)?)?)?
[error] java.util.zip.ZipException: duplicate entry: META-INF/MANIFEST.MF
...
[error]
D:\tmp\pekko102\apache-pekko-1.0.2-incubating-src-20231115\actor\src\main\java\org\apache\pekko\util\Unsafe.java:25:23:
not found: value sun
[error] public static final sun.misc.Unsafe instance;
[error] ^
I rarely run sbt, so this could easily be my local setup. I didn't
try my linux box. Maybe it would have worked there.
I also tested the artifacts in the staging repo with a simple typed
actors example in Groovy:
https://github.com/paulk-asert/groovy-pekko-gpars/tree/main/src/main/groovy/pekko
I used Groovy 4.0.15, the 1.0.2-RC1 artifacts and the Scala 2.13 runtime.
It ran without problems.
Cheers, Paul.
On Sat, Nov 18, 2023 at 11:56 PM PJ Fanning <fannin...@apache.org> wrote:
>
> Hello Incubator Community,
>
> This is a call for a vote to release Apache Pekko(incubating)
> Core version 1.0.2-RC1.
>
> The discussion thread:
> https://lists.apache.org/thread/zy84yk5gxp54bkn81ntlj5ps5o2z9w4j
>
> Pekko Vote Thread
> https://lists.apache.org/thread/0ojxypkm650bhk6pf53cp7h8036jgyol
>
> Pekko Result:
> https://lists.apache.org/thread/mh398gtjm751fq4fhss5c0xfwxnvx2xy
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/pekko/1.0.2-RC1/
>
> This release has been signed with a PGP key, available here:
>
> https://dist.apache.org/repos/dist/release/incubator/pekko/KEYS
>
> Git branch for the release:
>
> https://github.com/apache/incubator-pekko/tree/v1.0.2-RC1
> Git commit ID: 58fa510455190bd62d04f92a83c9506a7588d29c
>
> Release Notes:
>
> https://nightlies.apache.org/pekko/docs/pekko/1.0/docs/release-notes/index.html#1-0-2
>
> Please download, verify, and test.
>
> We have also staged jars in the Apache Nexus Repository. These were
> built with the same code
> as appears in this Source Release Candidate. We would appreciate if
> users could test with these too.
> If anyone finds any serious problems with these jars, please also
> notify us on this thread.
>
> https://repository.apache.org/content/groups/staging/org/apache/pekko/
>
> In sbt, you can add this resolver.
>
> resolvers += "Apache Pekko Staging" at
> "https://repository.apache.org/content/groups/staging";
>
>
> The vote will be left open for at least 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> To learn more about Apache Pekko, please see https://pekko.apache.org/
>
> Checklist for reference:
>
> [ ] Download links are valid.
> [ ] Checksums and signatures.
> [ ] LICENSE/NOTICE files exist
> [ ] No unexpected binary files
> [ ] Source files have ASF headers
> [ ] Can compile from source
>
> To compile from the source, please refer to:
>
> https://github.com/apache/incubator-pekko/blob/main/README.md#building-from-source
>
> Some notes about verifying downloads can be found at:
>
> https://pekko.apache.org/download.html#verifying-downloads
>
>
> Here is my +1 (binding).
>
> Thanks,
>
> PJ Fanning
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
