It's not an issue what the binary files are used for, the issue exists when the binary files are not reviewable.
My questions: - Do they have to be binary files in tests? - How are they generated? You don't have to generate these files on testing, but I'd expect to see the source files that generate these binary files. ————————— Ke (柯振旭) GitHub @kezhenxu94 ASF member > On Aug 16, 2023, at 08:43, tison <wander4...@gmail.com> wrote: > >> The following binary files should be addressed > > They are not "unexpected" binary files but testfile. I remember Flink hosts > similar "binary files" for verifying checkpoint migrations[1]. > > Since they are for regression tests, generating on testing seems > meaningless. > > Best, > tison. > > [1] > https://github.com/apache/flink/blob/master/flink-streaming-java/src/test/resources/win-op-migration-test-accum-aligned-flink1.3-snapshot > > > kezhenxu94 <kezhenx...@apache.org> 于2023年8月16日周三 08:24写道： > >> +1 (binding), there are some issues you might want to fix in future >> releases. >> >> - shasum is correct. >> - tarball is signed by Jun Ouyang <junouy...@apache.org>. >> - LICENSE, NOTICE, DISCLAIMER are in place. >> - The following binary files should be addressed: >> >> ./apache-opendal-incubating-0.39.0-src/core/tests/data/normal_file >> ./apache-opendal-incubating-0.39.0-src/core/tests/data/special_file >> !@#$%Ü&()_+-=;', >> >> - The following files are lack of license headers: >> >> examples/rust/00-setup/Cargo.toml >> examples/rust/00-setup/src/main.rs >> examples/rust/01-init-operator/Cargo.toml >> examples/rust/01-init-operator/src/main.rs >> examples/rust/02-async-io/Cargo.toml >> examples/rust/02-async-io/src/main.rs >> >>> On Aug 2, 2023, at 23:11, Jun Ouyang <junouy...@apache.org> wrote: >>> >>> Hello Incubator PMC, >>> >>> The Apache OpenDAL community has voted and approved the release of Apache >>> OpenDAL(incubating) v0.39.0-rc2. We now kindly request the IPMC members >>> review and vote for this release. >>> >>> OpenDAL is a data access layer that allows users to easily and >> efficiently >>> retrieve data from various storage services in a unified way. >>> >>> OpenDAL community vote thread: >>> >>> https://lists.apache.org/thread/7f9x4znmghj5k48f6yhyoho8q0lbs67c >>> >>> Vote result thread: >>> >>> https://lists.apache.org/thread/3g08w0b1h5187fq94l4y9gw8vlqw322g >>> >>> The release candidate: >>> >>> https://dist.apache.org/repos/dist/dev/incubator/opendal/v0.39.0-rc2/ >>> >>> This release has been signed with a PGP available here: >>> >>> https://downloads.apache.org/incubator/opendal/KEYS >>> >>> Git branch for the release: >>> >>> https://github.com/apache/incubator-opendal/tree/release-0.39.0-rc2 >>> >>> Please download, verify, and test. >>> >>> The VOTE will pass after got 3 binding approve. >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> To learn more about apache opendal, please see >> https://opendal.apache.org/ >>> >>> Checklist for reference: >>> >>> [ ] Download links are valid. >>> [ ] Checksums and signatures. >>> [ ] LICENSE/NOTICE files exist >>> [ ] No unexpected binary files >>> [ ] All source files have ASF headers >>> [ ] Can compile from source >>> >>> More detailed checklist please refer to: >>> https://github.com/apache/incubator-opendal/tree/main/scripts >>> >>> To compile from source, please refer to: >>> https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md >>> >>> >>> >>> -- >>> *GPG public key: 4A6D297E6F74638E4D5F8E99152AC7B5F7608B26* >>> *Thanks,* >>> *Jun Ouyang* >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
