Thanks Xuanwo for the explanation. +1 (binding)
- I checked the downloads and the SHA512 and ASC files are valid. - LICENSE/NOTICE/DISCLAIMER are fine - no binary files - ASF headers on source files - `cargo build` works fine On Wed, 28 Jun 2023 at 17:43, Xuanwo <[email protected]> wrote: > > Thanks for raising those questions! > > - For > https://github.com/apache/incubator-opendal/blob/a8ae017877d38a4362099eab6380d8f54fa4ab6f/core/src/raw/http_util/body.rs#L94 > > `Borrow` here is more like `Inspired`, we don't take hyper's code directly. > We should update the comments here. > > hyper code can be found here: > https://docs.rs/hyper/latest/src/hyper/body/to_bytes.rs.html#47-82 > > - For > https://github.com/apache/incubator-opendal/blob/a8ae017877d38a4362099eab6380d8f54fa4ab6f/core/src/services/memcached/backend.rs#L275 > > memcached service has been completely rewritten and no longer contains any > code from bb8-memcached. The comment here is outdated and needs to be updated. > > On Wed, Jun 28, 2023, at 23:08, PJ Fanning wrote: > > The release looks good to me, generally. > > > > I'm wondering about your LICENSE [1] though. > > It doesn't appear to acknowledge some third party code that is borrowed [2] > > [3]. > > > > Apologies if this has been addressed before but I can't find any > > discussion about this in previous vote threads. > > > > > > > > [1] https://github.com/apache/incubator-opendal/blob/main/LICENSE > > [2] > > https://github.com/apache/incubator-opendal/blob/a8ae017877d38a4362099eab6380d8f54fa4ab6f/core/src/raw/http_util/body.rs#L94 > > [3] > > https://github.com/apache/incubator-opendal/blob/a8ae017877d38a4362099eab6380d8f54fa4ab6f/core/src/services/memcached/backend.rs#L275 > > > > On Wed, 28 Jun 2023 at 15:31, Chojan Shang <[email protected]> wrote: > >> > >> Hello Incubator PMC, > >> > >> The Apache OpenDAL community has voted and approved the release of Apache > >> OpenDAL(incubating) 0.38.0-rc1. We now kindly request the IPMC members > >> review and vote for this release. > >> > >> OpenDAL is a data access layer that allows users to easily and efficiently > >> retrieve data from various storage services in a unified way. > >> > >> OpenDAL community vote thread: > >> > >> https://lists.apache.org/thread/ny0t1szlkrb8060j0w9gnj45oov18snm > >> > >> Vote result thread: > >> > >> https://lists.apache.org/thread/0l64s4w4yh19nzgfhg3cslm7cq10k7yd > >> > >> The release candidate: > >> > >> https://dist.apache.org/repos/dist/dev/incubator/opendal/0.38.0-rc1/ > >> > >> This release has been signed with a PGP available here: > >> > >> https://downloads.apache.org/incubator/opendal/KEYS > >> > >> Git branch for the release: > >> > >> https://github.com/apache/incubator-opendal/tree/release-0.38.0-rc1 > >> > >> Please download, verify, and test. > >> > >> The VOTE will pass after got 3 binding approve. > >> > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove with the reason > >> > >> To learn more about apache opendal, please see https://opendal.apache.org/ > >> > >> Checklist for reference: > >> > >> [ ] Download links are valid. > >> [ ] Checksums and signatures. > >> [ ] LICENSE/NOTICE files exist > >> [ ] No unexpected binary files > >> [ ] All source files have ASF headers > >> [ ] Can compile from source > >> > >> More detailed checklist please refer to: > >> https://github.com/apache/incubator-opendal/tree/main/scripts > >> > >> To compile from source, please refer to: > >> https://github.com/apache/incubator-opendal/blob/main/CONTRIBUTING.md > >> > >> > >> Thanks. > >> > >> Sincerely, > >> PsiACE > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > -- > Xuanwo > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
