Hi Justin, Thanks for your check.
> I’m not 100% sure but there might be some 3rd party code in the release not mentioned in LICENSE. There a copyright 2018 mentioned here [1] The copyright word mentioned in this file that is planned to be used to display the copyright information in the front end page. This file does not contain 3rd party codes and were developed under Apache 2.0 license. > and possibly some react code here [2] and elsewhere? Yes you are right. There are 3rd party codes in this file. We may have missed this check. -- Zhang Yonglun Apache ShenYu (Incubating) Apache ShardingSphere Justin Mclean <jus...@classsoftware.com> 于2021年10月21日周四 下午4:42写道： > Hi > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes are fine > - disclaimer exists > - notice and license look good > - all source files have ASF header > - no unexpected binary files > - can compile from source > > I’m not 100% sure but there might be some 3rd party code in the release > not mentioned in LICENSE. There a copyright 2018 mentioned here [1] and > possibly some react code here [2] and elsewhere? > > Kind Regards, > Justin > > 1. ./shenyu-dashboard/src/layouts/UserLayout.js > 2. ./shenyu-dashboard/src/components/GlobalFooter/index.md > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
