Hi, Panev I checked the mxnet project again, and I found that all the files in the third-party submodule ./3rdparty/ctc_include did not include ASF headers.
Best regards, Xun Liu On Mon, Sep 13, 2021 at 3:21 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) as issues brought up from the last RC have not been fixed, > namely: > - These files incorrectly have an ASF header [1][2][3] > - This is not mentioned in LICENSE [4][5]. A quick search shows about 20 > files with a Microsoft copyright (some are listed below). > > I also checked: > - incubating in release name > - signature and hashes were file > - LICENSE is missing information > - NOTICE looks fine > - some files have incorrect headers > - no unexpected binary files > - didn’t compile from source > > Other license issues [6][7][8][9][10][11][12][13][14][15] > > I did not do a full check of LICENSE and NOTICE or all files, but suspect > there are more issues, as every time I go looking I find something. I think > if would be good if the PMC do a review of all 3rd party files included > within the release. > > Kind Regards, > Justin > > 1. ./src/operator/numpy/np_einsum_op.cc > 2. ./src/operator/numpy/np_einsum_op-inl.h > 3. ./src/operator/numpy/np_einsum_path_op-inl.h > 4. ./src/operator/contrib/deformable_psroi_pooling.cu > 5. ./include/dmlc/ > 6. ./include/dlpack/dlpack.h > 7. ./include/dmlc/ > 8. ./src/operator/contrib/deformable_psroi_pooling-inl.h > 9. ./src/operator/contrib/deformable_psroi_pooling.cc > 10. ./src/operator/contrib/deformable_psroi_pooling.cu > 11. ./src/operator/contrib/multi_proposal-inl.h > 12. ./src/operator/contrib/multi_proposal.cc > 13. ./src/operator/contrib/multi_proposal.cu > 14. ./src/operator/contrib/psroi_pooling.cc > 15. ./src/operator/contrib/psroi_pooling.cu > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
