Hi, my +1, I’ve checked - Sha sum is OK - GPG signature verified. - RC matches the git tag / branch. - LICENSE, NOTICE, DISCLAIMER-WIP files exist. - Docs, release names include “Incubating”.
However the following issue is not a blocker of the release and can be fixed in the following releasees, but I found the headers in these files are not the one ASF specified. Note that there is dedicated license header for ASF projects, see this link [1] - plugins/databases/clickhouse/src/main/java/org/apache/hop/databases/clickhouse/ClickhouseDatabaseMeta.java - plugins/databases/clickhouse/src/test/java/org/apache/hop/databases/clickhouse/ClickhouseDatabaseMetaTest.java - plugins/databases/snowflake/src/main/java/org/apache/hop/databases/snowflake/SnowflakeDatabaseMeta.java - plugins/databases/snowflake/src/test/java/org/apache/hop/databases/snowflake/SnowflakeDatabaseMetaTest.java - plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnActionExtensionPoint.java - plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnActionExtensionPoint.java - plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnPipelineHopExtensionPoint.java - plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnTransformExtensionPoint.java - plugins/misc/git/src/main/java/org/apache/hop/git/DrawDiffOnWorkflowHopExtensionPoint.java - plugins/misc/git/src/main/java/org/apache/hop/git/HopDiff.java - plugins/misc/git/src/main/java/org/apache/hop/git/dialog/DeleteBranchDialog.java - plugins/misc/git/src/main/java/org/apache/hop/git/dialog/MergeBranchDialog.java - plugins/misc/git/src/main/java/org/apache/hop/git/dialog/UsernamePasswordDialog.java - plugins/misc/git/src/main/java/org/apache/hop/git/model/UIFile.java - plugins/misc/git/src/main/java/org/apache/hop/git/model/UIGit.java - plugins/misc/git/src/main/java/org/apache/hop/git/model/revision/GitObjectRevision.java - plugins/misc/git/src/test/java/org/apache/hop/git/HopDiffTest.java - plugins/misc/git/src/test/java/org/apache/hop/git/model/UIGitTest.java - core/src/main/java/org/apache/hop/core/util/StorageUnitConverter.java [1] https://www.apache.org/legal/src-headers.html#headers > On Mar 30, 2021, at 22:43, Hans Van Akelyen <hans.van.akel...@gmail.com> > wrote: > > Hi Incubator team, > > We are proud to announce that we have a new release candidate ready for > release and would like your review and vote. > > Build instructions can be found in the README included. > > Hop community vote and result threads: > Vote: > > https://lists.apache.org/thread.html/r24f1435c891c11d87d20d87d832b5de2613a37cda5e92c3587f058d1%40%3Cdev.hop.apache.org%3E > Result: > > https://lists.apache.org/thread.html/red37c2870bd3c366426579ffdd1c33c845eaf13801fd81bc0bd74539%40%3Cdev.hop.apache.org%3E > > The tag to be voted on is 0.70-rc1 (commit > f16b78f1a16feac5021f4556b30ee0a9609dbc1a) > https://github.com/apache/incubator-hop/tree/0.70-rc1 > > The release files, including signatures, digests, etc. can be found at: > https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.70-incubating-rc1/ > > The SHA512 Checksum for these artifacts is: > bbf9357801d9bdd0560a6788c7e51d469777d9dbf483be10d67e674552da28848edfba8533bab280afb97949ec55454ec5e147b73ce733010efa57af1997ef3d > > Release artifacts are signed with the following key: > https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x9a8a628dd4f4aa1e > > For more information about the contents of this release, see: > https://issues.apache.org/jira/projects/HOP/versions/12349578 > > Please vote on releasing this package as Apache Hop (incubating) 0.70! > > The vote is open for 72 hours and passes if > a majority of at least 3 +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Hop (incubating) 0.70 > [ ] +0 No opinion > [ ] -1 Do not release this package because ... > > Best Regards, > Hans ————————— Zhenxu Ke (柯振旭) GitHub @kezhenxu94 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
