Hi, xiangdong
 thanks for helping review our project
> But if you read your Readme.md, you will find..
Yes indeed. If you have used `mvn clean package`, then using `mvn compile`
won't
be a problem.  We will go through the readme file and figure out how to
reorg the steps.

> Others:
Thanks, we will check our license and make sure our project has the right
license clarification. We're still learning the apache way :)

On Tue, Feb 9, 2021 at 10:48 PM Xiangdong Huang <saint...@gmail.com> wrote:

> Hi,
>
> > We've found that maybe you were using `mvn compile` to build the tubemq
> > project, in this case, the project may not be built successfully.
>
> But if you read your Readme.md, you will find `mvn compile` command... So
> it should be fixed.
>
> Others:
>
> - Seems all Readme.md files have no Apache-rat.
> - I am not sure whether I am right: many projects have a LICENSE-binary
> file that list all 3rd part dependencies... e.g., hadoop [1] and IoTDB [2],
> but TubeMQ only lists license files from all modified/copied source files.
>
> [1] https://github.com/apache/hadoop/blob/trunk/LICENSE-binary
> [2] https://github.com/apache/iotdb/blob/master/LICENSE-binary
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
>  黄向东
> 清华大学 软件学院
>
>
> Yuanbo Liu <liuyuanb...@gmail.com> 于2021年2月8日周一 下午10:31写道:
>
> > Hi Justin
> >     We've found that maybe you were using `mvn compile` to build the
> tubemq
> > project, in this case, the project may not be built successfully.
> >     This project has some plugins executed in phase `package`, `mvn clean
> > package` seems to work well. Could you please try the command and
> >     check whether it works as expected.
> >
> > On Mon, Feb 8, 2021 at 7:57 PM Goson zhang <gosonzh...@apache.org>
> wrote:
> >
> > >  Thanks, professional and meticulous!!
> > >
> > > We'll check carefully again.
> > >
> > > Yuanbo Liu <liuyuanb...@gmail.com> 于2021年2月8日周一 上午10:25写道:
> > >
> > > > Hi, Justin
> > > >   Thanks for your check.
> > > >   I'll try to find out why you cannot compile. We will send a new
> > > > pending-release source for you to review before we start a new thread
> > for
> > > > voting. Is that ok with you?
> > > >   Thanks again for guiding our project.
> > > >
> > >
> >
>

Reply via email to