Hi, +1 (binding) but the NOTICE file need updating to include “This product includes software developed at…"
I checked: - incubating in names - signatures and hashes are file - LICENSE is fine - NOTICE is a bit too minimal please see [1] - all source files have ASF headers - no unexpected binary files - can’t compile but think I may have the wrong version of protobuf installed Thanks, Justin 1. https://www.apache.org/licenses/NOTICE-2.0.txt --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
