HI,

Sorry but it’s -1 (binding) due to license and binary issues

I checked:
- Incubating in name
- signatures and hashes are fine
- DISCLAIMER exists
- NOTICE include lists MIT licensed file this should be in LICENSE. This was 
brought up last release.
- LICENSE is missing above MIT license
- Release include code with incompatibles licenses (see below)
- Looks like there are compiled binaries in the source release [1]
- Can compile from source

I see a number of issues here file have been include that should not be as they 
contain:
"NOTE: these external pre-packaged configurations are not part of the official
# Apache source release due to CC BY 4.0 licensing.” 

That are include in the source release.

Files include:
./nlpcraft/src/main/resources/spell/dictionary.yaml
./nlpcraft/src/main/resources/geo/metro.yaml
./nlpcraft/src/main/resources/geo/continents.yaml
./nlpcraft/src/main/resources/geo/synonyms/states.yaml
./nlpcraft/src/main/resources/geo/synonyms/case_sensitive/list.yaml
./nlpcraft/src/main/resources/geo/synonyms/list.yaml
./nlpcraft/src/main/resources/geo/exceptions/dict.yaml
./nlpcraft/src/main/resources/geo/us_top.yaml
./nlpcraft/src/main/resources/geo/countries/GB.yaml
./nlpcraft/src/main/resources/geo/countries/US.yaml
./nlpcraft/src/main/resources/geo/countries/RU.yaml
./nlpcraft/src/main/resources/geo/world_top.yaml

Thanks,
Justin

1. ./nlpcraft/src/main/resources/opennlp/en-*.bin


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to