Thanks! I backed out the md5 hashes in favor of sha512 ones. Op za 2 mei 2020 om 07:47 schreef Justin Mclean <jus...@classsoftware.com>: > > Hi, > > -1 (binding) but +1 (binding) as soon as you fix the hash issue and there no > need to call another vote. > > I checked: > - incubating in name > - signatures correct > - hash needs to be a sha256 or sha512 as md5 is no longer recommended > - DISCLAIMER exists, thanks for mentioning the issues in here > - LICENSE looks OK, but as per disclaimer may be missing something, It also > contains a category B license as mentioned > - NOTICE year need updating > - There are unexpected binary files as noted > - Not all ASF file have headers as noted > - I don’t have an environment set up so didn’t try to compile > > Some other minor issues: > - The README needs updating as out points to non-Apache sites > - At some point you’ll need to move off or transfer > https://www.modpagespeed.com. > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
--------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
