Hi,

+1 from me (binding, carrying over my vote).

I checked:

- Incubating in name
- DISCLAIMER exists
- LICENSE is fine
- NOTICE should be fixed (which is a minor issue)
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
- Apache rat checks are OK

Kind Regards,
Furkan KAMACI

On Tue, Apr 28, 2020 at 4:56 AM Paul King <pa...@asert.com.au> wrote:

> +1 (binding)
>
> Checked:
> + DISCLAIMER exists
> + incubating in name
> + no unexpected binary files
> + signature okay (from
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS)
> + checksum okay
> + LICENSE okay
> + NOTICE lines 1-5 correct (remove lines 6-95 for next release, they aren't
> appropriate for the src release just binary)
> + mvn verify PASSES on JDK8 (checks for invalid JDK version - nice)
> + mvn apache-rat:check -Prelease PASSES (excludes look good; possibly
> "javadoc" no longer required?)
> + mvn package PASSES (still a few warnings creating javadoc; NOTICE file
> doesn't appear in created all-deps jar, this would be a full bindist
> variant with current content)
>
> On Thu, Apr 23, 2020 at 3:52 PM Aaron Radzinski <aradzin...@datalingvo.com
> >
> wrote:
>
> > Hello all,
> > This is a call for a vote to release Apache NLPCraft (incubating) version
> > 0.5.0.
> >
> > The Apache NLPCraft community has voted on and approved a proposal to
> > release Apache NLPCraft (Incubating) version 0.5.0. We would like to
> > request the Incubator PMC members review and vote on this incubator
> > release.
> >
> > Apache NLPCraft is a Java-based library for adding a natural language
> > interface to any applications. Notice that this is a first ASF release
> for
> > the NLPCraft community.
> >
> > Release information:
> > 1. Vote result thread:
> >
> >
> https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202004.mbox/%3CCACwEJt9LEqEJw7gVxS%3D56d%2BA%3DZewjBBEbQQJY%3D%2B6o7N7P-%3D0Ag%40mail.gmail.com%3E
> > 2. Release location:
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/
> > 3. Git tag:
> >
> >
> https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft.git;a=tag;h=refs/tags/v0.5.0
> > 4. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347774
> >
> > Quick links:
> > 1. ZIP archive:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip
> > 2. PGP signature:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.asc
> > 3. SHA256 signature:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/apache-nlpcraft-incubating-0.5.0.zip.sha256
> > 4. KEYS file:
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/KEYS
> >
> > NOTE: the 'dist' location has double 'nlpcraft' folders which may look
> > suspicious. First 'nlpcraft' is a root for the project, while the second
> > denotes core project name. Note that we'll be releasing our sub-projects
> > (i.e. java client) under the root 'nlpcraft' folder so the dist location
> > will eventually have structure like this:
> > -- nlpcraft
> >   |-- nlpcraft
> >   |-- nlpcraft-java-client
> >   |-- nlpcraft-web-ui
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > --
> > Aaron Radzinski
> >
>

Reply via email to