Hi, +1 (binding) but license need a little work. Please fix before the next release.
I checked: - incubating in name - signatures and hashes are fine - DISCLAIMER exists - LICENSE is missing a license - NOTICE is fine - No unexpected binary files - all source files have ASF headers LICENSE file is missing license for: - jquery.requestAnimationFrame Copyright (c) 2012 Corey Frang in [1] This is also missing in licenses. - Sizzle.js in [2] This is also missing in licenses. This is one danger with including minified files. Thanks, Justin 1. ./pinot-controller/src/main/resources/webapp/js/lib/foundation/foundation.js 2, ./pinot-controller/src/main/resources/webapp/js/lib/jquery-2.1.3.min.js --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
