Thanks, Justin! Do you have a link that explains more about where to put what for LICENSE and NOTICE?
>From what I'd understood LICENSE was to remain the pure Apache License 2.0 >text and NOTICE should contain any reference to any other copywritten material >contained within the repo--though it seems we missed bringing in the complete >license text either place. Happy to correct this once I understand which thing >is needed. Also when you say "incubating in name" what is the context (and is that a positive or negative comment)? Also, what binary files did you find in the release? Thanks! Benjamin -----Original Message----- From: Justin Mclean <jus...@classsoftware.com> Sent: Sunday, March 15, 2020 4:03 AM To: general@incubator.apache.org Subject: Re: [VOTE] Release Apache Annotator (incubating) 0.1.0 (-rc.2) Hi, -1 (binding) as LICENSE issues mentioned on the last RC have not been fixed and this release is not using the work in progress disclaimer. I checked: - incubating in name - LICENSE is missing 3rd party license information and full text of licenses is not include - NOTICE incorrectly mentions licenses - No binary files in release - This file is missing an ASF header [1]. although it may come from here [2] and if so needs to be mentioned in LICENSE. (Note running Apache Rat on this release shows that issue.) - Can compile from source Thanks, Justin 1. apache-annotator-0.1.0-incubating/packages/dom/src/highlight-range.js 2. https://github.com/Treora/dom-highlight-range --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
