Thanks， justin.
Any more feedback?
在 2020/2/21 上午9:39，“Justin Mclean”<jus...@classsoftware.com> 写入:
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exists (WIP version)
- LICENSE and NOTICE are good
- No unexpected binary files (although it is unusual to see .pttx files)
- All source files have ASF headers - the source file could be better
organised to make this easier to check
- I didn’t;t try to compile from source
I will note there are still files under the CDDL license which are Category
B and GPL license with is Category X and can’t normally be included in a source
release but this it OK with the WIP disclaimer. It would be better if the
disclaimer specifically called this out.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
