HI, +1 (binding) there are some license issues but they are to do with permissive licenses. My vote is conditional on this being fixed for the next release. Other IPMC member might consider voting -1.
I checked: - incubating in name - signatures and hashes are fine - DISCLAIMER exists (not WIP) - LICENSE is missing some items - NOTICE is missing information - Some file are missing ASF headers [3][4][5] although it could be argued that these are not very interesting files. - No unexpected binaries - can compile from source LICENSE is missing license information on this file [1]. Given that the file is only a "Slightly modified version” it should IMO not have an ASF header. LICENSE is missing information in these files [2][3] and missing the text of the license as required by the MIT license. For [1] does a NOTICE file exist? If so information from that NOTICE file would need to be moved into your NOTICE file. BTW a simple Rat check showed the above issues are you using rat and looking at the output? Thanks, Justin 1. ./dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java 2. ./dolphinscheduler-ui/src/sass/common/_animation.scss 3. /dolphinscheduler-ui/src/sass/common/_normalize.scss 4. ./docker/docker-compose.yml 5. ./dolphinscheduler-ui/src/lib/external/config.js 6../dolphinscheduler-ui/src/lib/external/email.js --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
