Hi Justin, Daniel from Danske Commodities has incorporated and addressed the comments here. Please take a look at the repo again and let us know what you think.
Thanks, Sijie On Fri, Feb 14, 2020 at 10:21 AM Sijie Guo <guosi...@gmail.com> wrote: > + Daniel in the loop. > > Thanks, > Sijie > > On Fri, Feb 14, 2020 at 10:20 AM Sijie Guo <guosi...@gmail.com> wrote: > >> >> >> On Fri, Feb 14, 2020 at 12:45 AM Justin Mclean <jus...@classsoftware.com> >> wrote: >> >>> Hi, >>> >>> I notice the LICENSE fine incorrect states in the appendix "Copyright >>> 2018 Daniel Blankensteiner” and the files are marked "Licensed to the >>> Apache Software Foundation (ASF)” this is not correct until after the >>> donation is accepted. >>> >>> Previously the file has no headers, was there any 3rd party code in >>> there? >>> >> >> Ah, I see. I helped to update the license header in preparing to >> transfer the repo to the ASF and I used the license header used in Apache >> Pulsar. >> https://github.com/danske-commodities/dotpulsar/commit/fb6b6fb898d3d707ab8ceba94a0824e96e5d009d >> >> >> Because I see that it was recommended to check and make sure that the >> files that have been donated have been updated to reflect the new ASF >> copyright. I might misunderstand the process here. Do I need to remove >> "Licensed to the Apache Software Foundation (ASF)"? >> >> >> >>> >>> The distribution right are "Danske Commodities A/S” in teh grant but >>> that doesn’t match with the (incorrect) copyright statement why is this? >>> >> >> I didn't catch "Copyright 2018 Daniel Blankensteiner" in the appendix. I >> will follow up with the team about this. >> >> >>> >>> Thanks, >>> Justin >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>> For additional commands, e-mail: general-h...@incubator.apache.org >>> >>>
