Paul, WRT the year bump on Copyright notices.
It is my understanding that if a file has not been substantially changed, that it is not necessary to change the year on a Copyright notice every time the year rolls over. As for the NOTICE file, it has not changed at all. So it should not be necessary to change the year, unless, somehow, the NOTICE file is special. If you look at these NOTICE files: for Hadoop, it is still dated 2006; Spark is dated 2014; Beam is 2016-2018, PDFBox is 2014. Clearly this rule, if it is truly legally required, is not consistently implemented. Is my understanding correct? Lee. On Sat, Jan 25, 2020 at 3:19 PM Paul King <pa...@asert.com.au> wrote: > +1 (binding) with one minor comment > > Checked: > * incubating in name > * DISCLAIMER-WIP exists > * LICENSE > * NOTICE (year bump needed 2019 => 2019-2020 as already noted by Justin) > * no unexpected binary files > * signatures > * hash > * mvn clean install (1) > * mvn apache-rat:check > > (1) Works on Linux. On Windows, some tests fail with: > java.nio.file.InvalidPathException: Illegal char <:> at index 2 ... > I note your comment in the install/test guide about "path elements must not > have any non-Java identifier characters" > but it wasn't clear to me that it would impact the test suite on Windows or > whether I could do anything to avoid the problem. > > Cheers, Paul. > > > On Thu, Jan 23, 2020 at 11:56 AM leerho <lee...@gmail.com> wrote: > > > Hello IPMC and Apache DataSketches Community, > > > > 1. This is a call for vote to release Apache DataSketches-java version: > > 1.2.0-incubating-RC2 > > > > NOTE 1: This is the core Java component of the DataSketches library > > that includes all the sketch algorithms in production-ready packages. > These > > sketches can be called directly from this component or used in > conjunction > > with the adaptor components such as Hadoop Pig, Hadoop Hive, or the > > aggregator adaptors built into Apache Druid. > > > > NOTE 2: This release contains some signifiant merge speed performance > > improvements. See datasketches.apache.org web site for more details. > > > > A. Results from the PPMC vote: > > > > - 1 (+1 binding) vote, 2 (+1 non-binding) votes > > > > - The vote thread can be found at the Permalink: > > > > > > > https://lists.apache.org/thread.html/rcd938a0dcc74e5284cf2cb6d4eca268aafb143840f52ed7ac4bd6956%40%3Cdev.datasketches.apache.org%3E > > > > B. Testing/actions/votes performed by the voters in the PPMC Stage 1: > > > > - Alexander Saydakov (+1 non-binding) > > Checked: > > - verified signature and sha512 hash > > - mvn install > > > > - Jon Malkin (+1 non-binding) > > - verified signature and shasum > > - ran tests successfully > > - mvn install successfully > > > > - Furkan Kamachi (+1 binding) > > I checked: > > - Incubating in name > > - DISCLAIMER-WIP exists > > - LICENSE and NOTICE are fine > > - No unexpected binary files > > - Checked PGP signatures > > - Checked Checksums > > - Code compiles and tests successfully run > > > > 2. Source repository: > > - https://github.com/apache/incubator-datasketches-java > > > > Git Tag for this release: > > - > > > > > https://github.com/apache/incubator-datasketches-java/tree/1.2.0-incubating-RC2 > > on branch 1.2.X-incubating > > > > Git HashId for this release starts with: 97552af > > > > 3. The Release Candidate / Dist (Zip Repository): > > - > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/java/1.2.0-incubating-RC2/ > > > > The public signing key can be found in the KEYS file: > > - https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > > > > 4. Repository: [Nexus](http://repository.apache.org) (Jar Artifacts): > > - > > > > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/1.2.0-incubating/ > > > > 5. Build & Test Guide: > > - > > > > > https://github.com/apache/incubator-datasketches-java/blob/1.2.0-incubating-RC2/README.md > > > > 6. This vote is the 2nd stage vote: > > - This voting process will remain open for at least 72 hours > > and until at least 3 (+1) IPMC votes or a majority of (+1) are > > acquired. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > Lee Rhodes > > lee...@apache.org > > >
