Added DolphinScheduler dev ML to the reply. Hi DolphinScheduler PPMC
For commercial license files(font) included, although I will not change the vote to -1, but still recommend you to consider to cancel the vote. I know you have felt frustrating about failure and want to make a release ASAP. If you really think your end users are urgent for this release, you could make a call to continue and release. But to be honest, commercial license related license is not good for the end users too. Because every one who uses this release and don’t buy the front, is having license issue. Justin Mclean <[email protected]>于2019年12月13日 周五上午11:33写道： > Hi, > > +0 (binding) > > it would have been good to see some attempt at fixing the licensing > issues/LICENSE file, but I trust this will be done with future releases. > > I’m +0 rather than +1, even with the WIP disclaimer, for a few reasons: > - This release also contain content you probably don’t have permission to > distribute. [1] This has been discussed before [2] > - The release may include GPL code this should be made clear to the user > in the DISCLAIMER, I think it needs to be stronger than "Releases may have > incomplete licensing conditions” > - It seems to me that you may of included code you did not intend to > include in a source release [3]. there are 368 pieces of 3rd party code > there. None are mentioned in LICENSE. > - It seems some people voting checked what in GitHub rather than what was > in the source release > - Several people stated that "All software dependencies are mentioned in > LICENSE or NOTICE” when it’s clearly not the case > > I would suggest you cancel this RC and try again, but if you feel you need > to make a release and other IPMC member are happy with the above go for it. > > I checked: > -incubating in name > - DISCLAIMER exists (WIP version) > - LICENSE is missing a while lot of bundled 3rd party software e.g. > FontAwesome, IconFont, cookie,.js, e5 shim, bootstrap etc etc > - NOTICE is fine > - all source files have ASF headers (but they could be added to some .sql > files) > - no unexpected binary files > - can compile from source > > Thanks, > Justin > > 1. ./dolphinscheduler-ui/node_modules/wordwrap/test/idleness.txt > 2. > https://lists.apache.org/thread.html/c4067f42d963414d4d5fbaf66ee81f805133918f804e9f5eca2161e9%40%3Cdev.dubbo.apache.org%3E > 3. ./dolphinscheduler-ui/node/node_modules/npm/node_modules > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108
