Justin, Thank you for your vote!
WRT your questions: 1. LICENSE: Good suggestion, thanks, I will correct in master. This will need to be corrected in our other repository components as well. 2. The Google group / forum is still active. We plan to deprecate this and have users either use a user@ list (library wide) or GitHub issues, which are focused on a specific component (eg., Java, C++, Memory, Hive, etc.). This forum is mostly used by novices learning about the library. For "issues" and bugs users like to use the GitHub "issues". 3. The datasketches.github.io link has been widely used and published in articles, scientific papers, presentations, blogs, books, etc, and as soon as our website gets successfully moved this link will become a redirect to datasketches.a.o As soon as our website is moved, I will change these links to datasketches.a.o. throughout the library. Nonetheless this link will have to be a valid link for a long time. 4. File [1] authors. These folks were contributors to the code long before we decided to move to Apache. They were either employees of Yahoo, OR had signed CLA's with Yahoo. Therefore, by definition, all of the copyrights were licensed to ASF at the time we submitted the Copyright Grants to ASF early this year. Lee. On Fri, Nov 15, 2019 at 2:40 PM Justin Mclean <jus...@classsoftware.com> wrote: > HI, > > +1 (binding) > > I checked: > - incubating in name > - signatures ands hashes are fine > - includes DISCLAIMER > - LICENSE and NOTICE fine > - No unexpected binary file > - All source files have ASF headers > - Can compile from source > > In LICENSE I’d suggest you change the giuthub URLs to be relative file > paths (where the file exists locally) as what in GitHub may change from > what in the release. > > I notice the pox.mxl and README refers to a google group. Does this still > exist and is being used? This is also a number of datasketches.github.io > links mentioned. > > I notice this file [1] has an ASF header but lists a number of authors, > where did this code come from? There are a number of other author tags in > other files. Where these author tags pre-existing when the code was donated > or have they been added since? > > Thanks,. > Justin > > 1. /src/main/java/org/apache/datasketches/memory/AllocateDirectMap.java > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
