Hi Justin, Thanks for reviewing. Isn't this actually part of the IP clearance form which describes the following: > Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright.
Having a look at other IP clearances they are more or less doing the same (just picked 2 random ones): For Apache Arrow: http://incubator.apache.org/ip-clearance/arrow-gandiva.html which matches with pull request: https://github.com/apache/arrow/pull/2558 For Apache Beam: http://incubator.apache.org/ip-clearance/beam-zetasql-translator.html which matches with pull request: https://github.com/apache/beam/pull/9210 I noticed that Beam its NOTICE file already contained the statement that the project includes source code developed by Google. For Celix is it okay to continue if we update the NOTICE file and add the following statement?: This product includes software developed at Thales Nederland B.V. (https://www.thalesgroup.com/nl). Thanks, Roy Op wo 21 aug. 2019 om 06:06 schreef Justin Mclean <jus...@classsoftware.com >: > Hi, > > > The pull request containing the donation can be found at: > > https://github.com/apache/celix/pull/39 > > I can see that the copyright owner / headers have been replaces by ASF > ones. This is best done after accepting the donation and then adding that > copyright to NOTICE. > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
