Hi Justin, Thank you so much for taking the time to have a look and for the +1 vote.
> NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop and Apache Calcite. Only Calcite is mentioned in your NOTICE file and all of those projects have NOTICE files, Jets3t contains a NOTICE file [3] so I think more needs to go in your NOTICE file. I was not directly involved in this, but it is my understanding that the modifications to our source NOTICE file between 0.15.0-incubating and this version are a result of this thread on the IPMC vote, https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E. which suggested that the NOTICE files should contain only what is strictly required for the files actually contained in the bundle to which they apply. Based on this, only code we adapted from Apache Calcite fits this interpretation of how to construct NOTICE files, so we have removed the others that you listed for the source distribution NOTICE. NOTICE.BINARY still has the NOTICE file contents for those that you listed which we bundle (we don't bundle Lucene so it isn't present). https://github.com/apache/incubator-druid/pull/7945 is the pull request where the changes were done for reference. > I am sort of curious how this is licensed [1] and if that should go in LICENSE? (which I don’t think is an issue) and if you had permission from the people to use and distribute the content in [2] With regards to the 'lorem ipsum' text, I am unsure of how this is licensed and somewhat surprised how hard this seems to be to find out, but I will try to determine this (or replace the text with something else since it is just used for a compression test) before the next release. I believe the wikiticker-2015-09-12-sampled.json.gz data was collected by Gian Merlino from an IRC channel where a bot prints out all wikipedia edit activity in real-ish time. I don't know and haven't yet found out the ownership details of the contents of that IRC channel, I will try to follow-up and resolve this as soon as I figure out how to do so. Cheers, Clint On Fri, Aug 9, 2019 at 5:28 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - LICENSE is fine > - NOTICE may need a little work > - No unexpected binary files > - Source files have ASF headers > - Can compile from source > > NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop > and Apache Calcite. Only Calcite is mentioned in your NOTICE file and all > of those projects have NOTICE files, Jets3t contains a NOTICE file [3] so I > think more needs to go in your NOTICE file. > > I am sort of curious how this is licensed [1] and if that should go in > LICENSE? (which I don’t think is an issue) and if you had permission from > the people to use and distribute the content in [2] > > Thanks, > Justin > > 1. core/src/test/resources/loremipsum.txt > 2. > apache-druid-0.15.1-incubating-src/examples/quickstart/tutorial/wikiticker-2015-09-12-sampled.json.gz > 3. https://bitbucket.org/jmurty/jets3t/src/default/NOTICE.txt > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
