Thank you Paul. We will address all mentioned concerns in the next release.
- Josh On Sun, Jul 28, 2019 at 7:40 AM Paul King <pa...@asert.com.au> wrote: > +1 (binding) > > I checked: > - incubating in name > - DISCLAIMER present > - Signature and hashes okay > - LICENSE is missing a number of permissive licenses (I didn't check ones > Justin had already covered but third_party\python\semver seems to be > missing from list of BSD licensed software though it does appear in your > rat excludes - please add for next release) > - NOTICE has incorrect year (please update for next time) > - No unexpected binary files > - All ASF files have correct headers > - didn’t compile from source > > Cheers, Paul. > > > > On Fri, Jul 26, 2019 at 12:02 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signature and hashes fine > > - LICENSE is missing a number of permissive licenses (see below) > > - NOTICE has incorrect year (please update) > > - No unexpected binary files > > - All ASF file have correct headers > > - didn’t compile form source > > > > Licence is misisng > > - MIT licensed software copyright Facebook [1][2][3][4][5][6] > > - ALv2 files [7][8] > > - ALv2 files [9][10][11][12][13][14][15][16] > > - this ALv2 file [17] > > - this ALv2 file [18] > > - this ALv2 file [19] > > - this file [20] includes Sizzle (MIT, BSD, and GPL Licenses) > > - this file [21] includes modernizr (MIT licensed) > > > > (I just did a search for the word copyright and match what was listed in > > the LICENSE file if you’re wondering how I found these) > > > > Thanks, > > Justin > > > > 1. ./website2/website/core/Footer.js > > 2. ./website2/website/siteConfig.js > > 3. ./website2/website/pages/en/users.js > > 4. ./website2/website/pages/en/index.js > > 5. ./website2/website/pages/en/help.js > > 6. ./website2/website/pages/en/versions.js > > 7. ./tools/rules/pex/pex_rules.bzl > > 8. ./tools/rules/pex/wrapper/pex_wrapper.py > > 9. ./scripts/setup-eclipse.sh > > 10. ./scripts/detect_os_type.sh > > 11. ./scripts/get_all_heron_paths.sh > > 12. ./scripts/packages/template_bin.sh > > 13. ./scripts/packages/self_extract_binary.bzl > > 14. ./scripts/packages/package_info_generator.sh > > 15. ./scripts/packages/tests_template_bin.sh > > 16. ./scripts/packages/bin_common.sh > > 17. ../heron/shell/src/python/handlers/healthhandler.py > > 18. ./third_party/java/bazel/extra_actions_base.proto > > 19. > > > ./third_party/java/jarjar/src/main/resources/com/tonicsystems/jarjar/help.txt > > > > 20. ./heron/shell/assets/jquery.js > > 21 ./heron/tools/ui/resources/static/js/bootstrap.js > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > -- Sent from A Mobile Device
