Also, to clarify Zipkin 2.13 is a bridge release. The code that is readying for next week (2.14) changes functionality. We need this 2.13 code released regardless of what is in flight for next week to ensure people move off our pre-ASF group IDs ASAP.
Best, -A On Wed, May 8, 2019 at 8:02 AM Adrian Cole <adrian.f.c...@gmail.com> wrote: > > Thanks, Justin. there was a problem in our license header > configuration that updated that vendored subdirectory. I will revert > that part (and move the text in the wrong spot) in the next release > which will be next week. > https://github.com/apache/incubator-zipkin/issues/2567 > > Please let us know if this release can take place as-is. It is a lot > easier for us if we can as there has been a lot of movement on master > since. > > Best, > -A > > On Wed, May 8, 2019 at 6:03 AM Justin Mclean <jus...@classsoftware.com> wrote: > > > > Hi, > > > > I’ve not done a full check but noticed a couple of minor things: > > - NOTICE file contains LICENSE information that should be in LICENSE > > - LICENSE is missing licenses for [1][2] > > - The files [1][2] and [3] also incorrectly have had ASF headers added, > > there might be others. > > > > Thanks, > > Justin > > > > 1. ./zipkin-ui/libs/dagre-d3/js/dagre-d3.js > > 2. ./zipkin-ui/libs/chosen/chosen.css > > 3. ./zipkin-ui/libs/dagre-d3/js/dagre-d3.min.js > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
