Hi,

+1 (non-binding)

Hi,

I vote with:
 +1 release the software

 Are release files in correct location? Yes
 Do release files have the word incubating in their name? Yes
 Are the digital signature and hashes correct? Yes
 Does DISCLAIMER file exist? Yes
 Do LICENSE and NOTICE files exists? Yes
 Is the LICENSE and NOTICE text correct? Yes
 Is the NOTICE year correct? Yes
 Un-included software dependencies are not mentioned in LICENSE or NOTICE? Yes
 License information is not mentioned in NOTICE? Yes
Is there any 3rd party code contained inside the release? No
 Do all source files have ASF headers? Yes
 Do the contents of the release match with what's tagged in version
control? Yes
 Are there any unexpected binary files in the release? No.
 Can you compile from source? Are the instruction clear? Yes.
 UT passed on MacOS and Java 11
 All the 3rd party licenses are compatible with Apache License.

Minor issues:
- The following files does not has ASF license header, it is better to add it.
./dubbo-spring-boot-samples/auto-configure-samples/provider-sample/src/main/resources/application.properties
./dubbo-spring-boot-samples/auto-configure-samples/consumer-sample/src/main/resources/application.yml
./dubbo-spring-boot-samples/dubbo-registry-zookeeper-samples/provider-sample/src/main/resources/application.properties
./dubbo-spring-boot-samples/dubbo-registry-zookeeper-samples/consumer-sample/src/main/resources/application.yml
./dubbo-spring-boot-samples/externalized-configuration-samples/provider-sample/src/main/resources/application.properties
./dubbo-spring-boot-samples/externalized-configuration-samples/consumer-sample/src/main/resources/application.yml
./dubbo-spring-boot-actuator/src/main/resources/META-INF/dubbo-endpoins-default.properties
./dubbo-spring-boot-actuator/src/main/resources/META-INF/spring.factories
./dubbo-spring-boot-compatible/actuator/src/main/resources/META-INF/spring.factories
./dubbo-spring-boot-compatible/autoconfigure/src/test/resources/META-INF/dubbo.properties
./dubbo-spring-boot-compatible/autoconfigure/src/test/resources/META-INF/spring/dubbo-context.xml
./dubbo-spring-boot-compatible/autoconfigure/src/main/resources/META-INF/spring.factories
./dubbo-spring-boot-autoconfigure/src/test/resources/dubbo.properties
./dubbo-spring-boot-autoconfigure/src/main/resources/META-INF/spring.factories
- The sha512 checksum should be marked as '*', please use -b to
generate that token.
13d266f1f1c0352cdcb0a034d5147e3e5122adf37ef92a0d38af8b644ea5a302db3dd331ad7621967ab740966def061091e6b8acddcd0d500c4b74964228c3c1
 apache-dubbo-spring-boot-project-incubating-2.7.1-bin-release.zip
- It is better to change the file name to
apache-dubbo-spring-boot-project-incubating-2.7.1-bin.zip and
apache-dubbo-spring-boot-project-incubating-2.7.1-src.zip

On Thu, Apr 4, 2019 at 11:42 AM Mercy <mercybl...@apache.org> wrote:
>
> Hello all,
>
> This is a call for the vote to release Apache Dubbo Spring Boot Project 
> (Incubating) version 2.7.1
>
> The Apache Dubbo community has voted on and approved a proposal to release
> Apache Dubbo Spring Boot Project (Incubating) 2.7.1.
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> Apache Dubbo™ (incubating) is a high-performance, java based, open source
> RPC framework. Dubbo offers three key functionalities, which include
> interface based remote call, fault tolerance & load balancing, and
> automatic service registration & discovery.
>
> Dubbo community vote and result thread:
> https://lists.apache.org/thread.html/ded40621ad7572a84c71cc6ad5a9843c3e073e405d051e7053e8700b@%3Cdev.dubbo.apache.org%3E
>
> The release candidates :
> 2.7.1:https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.1
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1017
>
> Git tag for the release:
> 2.7.1: 
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/2.7.1
>
> Hash for the release tag:
> 2.7.1: 01fbe79c71f73f65ae1fa1239f9fba30a8300192
>
> Release Notes:
> 2.7.1: 
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/2.7.1
>
> The artifacts have been signed with Key: 
> 87F025027A831ED2B86E7F08A7F508EFDA68B4F5, which can be found in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number of 
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo (Incubating) Team
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org



--
Best Regards!
Huxing

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to