As Willem outlined, there is a few of minor header issues to fix but looks 
good.  I checked; Name, Sig and Hashes, Notice, License.

I tried to build on Ubuntu 18.10 following the instructions in the README but 
it fails.  Is this expected?

Would be happy to +1 if we are comfortable the source build “builds” as 
intended.

Cheers,
Dave

> On 20 Dec 2018, at 06:32, 德 李 <l...@apache.org> wrote:
> 
> The vote will be open for at least 72 hours.
> [ ] +1 Approve the release
> [ ] +0 No opinion
> [ ] -1 Do not release this package because ...
> 
> Best Regards,
> 
> Reed

Reply via email to