Hi, +1 (binding)
I checked: - incubating in name - signature and hashes correct - DISCLAIMER exits - LICENSE has a minor issue and missing BSB license text - NOTICE is fine - All ASF files have headers - No unexpected binary files - Don’t have the set up to compile but instructions look comprehensive The LICENSE is missing the text of the BSD license and the copyright notice in LICENSE. Please don’t include URL pointers to licenses but download them and include a pointer to that file. License can change over time and links can rot. Please fix for the next release. The LICENSE is also missing the license information of OMock (under the ALv2), it’s optional to mention but good for completeness. Note that this file [1] states "Copyright 2017 The Weex Authors” is that correct? Thanks, Justin 1. vi ./weex_core/Source/android/base/jni/scoped_java_ref.cpp --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
