+1 (binding) - signature ok - incubating in name - disclaimer file - notice and license (other than the line mentioned by Justin already) - included gradle wrapper in source tar does not work (seems to be missing the bootstrap jar) - nonetheless, builds fine with my system copy of gradle 4.8.1
Justin: that ConcurrentMapBackedCache.scala file is mentioned in LICENSE.txt as a 3rd party file. On Sat, 14 Jul 2018 at 02:01, Justin Mclean <justinmcl...@me.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signature and hashes fine > - DISCLAIMER exists > - LICENSE incorrectly has a filled in copyright line in the appendix > please fix > - NOTICE fine > - No unexpected binary file > - A few files are missing ASF headers (e.g. .sh files) and not sure this > file should have an ASF header [1] > - Can compile from source > > Thanks, > Justin > > > 1. > incubator-openwhisk-0.9.0-incubating/common/scala/src/main/scala/whisk/core/database/ConcurrentMapBackedCache.scala > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Matt Sicker <boa...@gmail.com>
