Hi Justin, While some of the issues are fixed in the correct branch (as we, unfortunately, packaged the wrong code with the release) I'm fixing some of the license issues you have found and have a couple of questions:
1. The gradle-wrapper.jar is a part of the standard Gradle project structure, and a quick search showed me that that other projects, such as Apache Beam do include it in their source releases. Do we need to do something specific to have an approval for gradle-wrapper.jar? 2. we use both PySpark and py4j in our integration tests (which we plan to remove in one of our next releases), which account for the majority of the files you have specified. Do we need to include a license for every sub-component of those, or a general one is enough? If so, PySpark is an Apache project so I believe no additional license is needed, is that correct? Thanks in advance, Yaniv On Wed, Jun 20, 2018 at 1:28 PM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Sorry but it’s -1 binding as there compiled code in the source release and > some software is of an unknown license > > I checked: > - incubating name > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a number of things > - NOTICE has incorrect year > - a number of source files are missing ASF headers > - there is an unexpected binary files in the source release [1] > - can compile from source > > LICENSE is missing license for these bundled files: > - Python license files [2][4] > - BSD license files [3][7][8] > - these files of unknown license [5][6] > > The MIT licensed file mentioned in LICENSE seems to be missing. > > Thanks, > Justin > > 1. incubator-amaterasu-version-0.2.0-incubating-rc3/gradle/ > wrapper/gradle-wrapper.jar > 2. executor/src/test/resources/py4j-0.10.4-src.zip/py4j/backport.py > 3. executor/src/main/resources/codegen.py > 4. executor/src/test/resources/pyspark.tar.gz/pyspark.tar/ > pyspark/heapq3.py > 5. executor/src/test/resources/py4j-0.10.4-src.zip/py4j/ > tests/memory_leak_test.py > 6 executor/src/test/resources/py4j.tar.gz/py4j.tar/py4j/protocol.py > 7. executor/src/test/resources/pyspark.tar.gz/pyspark.tar/ > pyspark/cloudpickle.py > 8 executor/src/test/resources/pyspark.tar.gz/pyspark.tar/pyspark/join.py > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yaniv Rodenski +61 477 778 405 ya...@shinto.io
