Thank you very much the review, Justin. I created [RATIS-248] and [RATIS-249] to address the issues.
We will create a new release candidate and restart the vote after the fixes. But if anybody see any _other_ issues, kindly ask to continue this thread and give us more feedback.
Thank you very much, Marton [RATIS-248]: https://issues.apache.org/jira/browse/RATIS-248 [RATIS-249]: https://issues.apache.org/jira/browse/RATIS-249 On 05/26/2018 03:08 AM, Justin Mclean wrote:
Hi, -1 (binding) as the release artefacts don’t include the word “incubating” [1] and LICENSE and NOTICE require work Please remove the md5 hashes as they should no longer be included. I checked: - incubator rather than incubating is in release artefact names - signatures and sha512 hashes good - DISCLAIMER exists - LICENSE is missing a BSD license - LICENSE and NOTICE include things that are not in the source release - No binary files in release - Can compile from source LICENSE is missing BSD license for these files [2][3][4]. Note that a condition of the BSD license is to include it’s text, the text is missing form the headers and not included in LICENSE. It also look like the LICENSE and NOTICE are listing dependance not what is actually bundled in the release. From what I can see for the source release LICENSE should be boiler place and include the BSD license mentioned above and nothing else, NOTICE should be boilerplate and a few lines long. Please review [5] and in particular the guiding principle. It likely that your convenience binary will need a different LICENSE and NOTICE. Thanks, Justin 1. https://incubator.apache.org/guides/releasemanagement.html 2. /ratis-incubator-0.2.0/ratis-common/src/main/java/org/apache/ratis/util/PureJavaCrc32C.java 3. /ratis-incubator-0.2.0/ratis-common/src/main/native/src/org/apache/ratis/util/bulk_crc32.c 4. /ratis-incubator-0.2.0/ratis-common/src/main/native/src/org/apache/ratis/util/bulk_crc32_x86.c 5. http://www.apache.org/dev/licensing-howto.html 6. http://www.apache.org/dev/licensing-howto.html#guiding-principle --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
--------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
