Hi, +1 (binding)
I checked: - incubating in name - DISCLAIMER exists - LICENSE is OK and NOTICE good - All source files have ASF headers - No unexpected binary files - Can compile from source Minor issue is that LICENSE is missing mention of these files [1][2][3] (but includes their license), be nice to fix that for the net release. Thanks, Justin 1. ./pulsar-client-cpp/lib/checksum/int_types.h 2. ./pulsar-client-cpp/lib/checksum/crc32c_sse42.h 3. ./pulsar-client-cpp/lib/checksum/crc32c_sse42.cc 4. ./pulsar-client-cpp/lib/checksum/gf2.hpp --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
