Hi Matt， I checked the vertx NOTICE.md[1] was added since 3.5.1[2], but we are using vertx 3.5.0[3].
BTW For the bundled Apache Licensed dependency, I checked the instruction[4], but it doesn't mention what should be put into the top-level NOTICE file. we will add a reference of it vertx NOTICE.md once we upgrade the vertx version. [1]https://github.com/eclipse/vert.x/blob/master/NOTICE.md [2] https://github.com/eclipse/vert.x/commit/cc05b9ddc558770a476a016578fbcfe97622de4b#diff-ce70fe65be0b8d1cbe0c667387c16c70 [3] https://github.com/apache/incubator-servicecomb-java-chassis/blob/ae28a9faff24e773520f3452dfd80b86dfbe7aa4/java-chassis-dependencies/pom.xml#L35 [4]http://www.apache.org/dev/licensing-howto.html#alv2-dep Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Fri, Mar 30, 2018 at 11:43 PM, Matt Sicker <boa...@gmail.com> wrote: > * Rat check ok (checked exceptions as well) > * Build and tests ok > * Signatures ok > > Question regarding the NOTICE file: shouldn't the vertx classes that are > bundled be noted here? > > On 29 March 2018 at 22:59, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > > > +1 (binding) > > > > Checked: > > - build > > - signatures and headers > > - DISCLAIMER/LICENSE/NOTICE are present > > > > NB: NOTICE looks very light to me. I would double check if it's complete > > and > > clean for the next release. > > > > Regards > > JB > > > > On 03/29/2018 04:23 PM, Mohammad Asif Siddiqui wrote: > > > Hi All, > > > > > > This is a call for vote to release Apache ServiceComb Java-Chassis > > (Incubating) version 1.0.0-m1 > > > > > > Apache ServiceComb (Incubating) Community has voted and approved the > > release. > > > > > > Vote Thread : https://lists.apache.org/thread.html/ > > 3614f836e1905fc5d80e65217cf0fb294bd075451cfa311bb68f3342@% > > 3Cdev.servicecomb.apache.org%3E > > > > > > Result Thread : https://lists.apache.org/thread.html/ > > 965e7745295679e39c2ea466b445abd87173df9d1482a84491ca84c2@% > > 3Cdev.servicecomb.apache.org%3E > > > > > > Release Notes : https://github.com/apache/incubator-servicecomb-java- > > chassis/blob/master/etc/releaseNotes.md > > > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-java-chassis/1.0.0-m1/ > > > > > > Staging Repo : https://repository.apache.org/content/repositories/ > > orgapacheservicecomb-1210 > > > > > > Release Tag : https://github.com/apache/incubator-servicecomb-java- > > chassis/releases/tag/1.0.0-m1 > > > > > > Release CommitID : b60bf88c053e9ffa63b671a6639195be5179cf90 > > > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > > > Voting will start now ( Thursday, 30th March, 2018) and will remain > open > > for next 72 hours, Request all PPMC members to give their vote. > > > > > > [ ] +1 Release this package as 1.0.0-m1 > > > [ ] +0 No Opinion > > > [ ] -1 Do not release this package because.... > > > > > > On the behalf of ServiceComb Team > > > Mohammad Asif Siddiqui > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > -- > > Jean-Baptiste Onofré > > jbono...@apache.org > > http://blog.nanthrax.net > > Talend - http://www.talend.com > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > -- > Matt Sicker <boa...@gmail.com> >
