Hi Justin,

Thanks for pointing that out.  I just filled a JIRA[1] for it and submit
quick fix for it.
[1]https://issues.apache.org/jira/browse/SCB-427


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
          http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Sat, Mar 24, 2018 at 8:22 AM, Justin Mclean <justinmcl...@me.com> wrote:

> Hi,
>
> Sorry but it’s -1 binding from me as the source release contains some
> CC-BY licensed content in plain text. [1][2] CC-BY is considered Category B
> [3] and can’t be included in a source release. These files also incorrectly
> IMO have ASF headers.
>
> Everything else is good. I checked:
> - name includes incubating
> - DISCLAIMER exists
> - LICENSE and NOTICE all good
> - No unexpected binary files
> - All source files have ASF headers
> - Can compile form source
>
> Thanks,
> Justin.
>
> 1. apache-servicecomb-incubating-java-chassis-distribution-1.0.
> 0-m1-src/etc/eclipse-java-google-style.xml
> 2. apache-servicecomb-incubating-java-chassis-distribution-1.0.
> 0-m1-src/etc/intellij-java-google-style.xml
> 3. https://www.apache.org/legal/resolved.html#category-b
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to