Thanks for reviewing!

On Sun, 14 Jan 2018 11:52:37 +1100, Justin Mclean <jus...@classsoftware.com> 
wrote:

> Has a mistake been made here? I can’t see any source code in the release.

There are two artifacts in the release: 

apache-taverna-parent-3-incubating-source-release.zip
apache-taverna-server-3.1.0-incubating-source-release.zip

The second is the actual source code - but it depends on the newer
apache-taverna-parent so they need to be built in that order.

(We have several git repositories, they all share taverna-parent)


> - NOTICE probably has too much information

Presuming you checked taverna-parent, are you suggesting to remove the text
about the software grant?


> - I'd like to say all source code has headers - except there's no source code
> - No unexpended binaries
> - Can “compile” successfully
> 
> Given there is basically nothing bundled here I can’t see any reason for the 
> extra information in NOTICE.
> 
> You might want to consider using sha512 for your sha hash. [1]

Thanks, I've added .sha256 and .sha512 files.

For the record (these lines will probably be wrongly wrapped)

6dcca32163870e33d99454388d43c818bc003e29a911f8fe6d48e63373d2aca5  
apache-taverna-parent-3-incubating-source-release.zip
0025c85cc115fc5b8c6c969f2a1ae995ca3269a193f63d2508bc8740c095af1c  
apache-taverna-server-3.1.0-incubating-source-release.zip

767aaf8cbe43eb62549e8c73619ce2170197cd625d23eeadb8d3df284d74c15a503c86c92741aac6c931208338c00b8409392c36fc965cc237b963143b7a7817
  apache-taverna-parent-3-incubating-source-release.zip
b08e568e4470b2db2b3e5754ae0eaba72990ab2f1f951dcd96f65a04fb768665391d8c50af2270045f659e1ab81dc881a217d4f0d64e3c2ef691e802cad11835
  apache-taverna-server-3.1.0-incubating-source-release.zip



---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to