+1 Checked: - signatures and hashes - can build from source - LICENSE and NOTICE - rat check
Thanks, Francis On Sun, Oct 8, 2017 at 10:04 PM Justin Mclean <justinmcl...@me.com> wrote: > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes good > - disclaimer exists > - LICENSE and NOTICE correct > - All ASF source files have ASF headers > - no unexpended binary file in source release > - Can compile from source > > I also checked the binary and while the LICENSE looks good the NOTICE is > missing information from other ALv2 bundled items. [1][2] Please fix for > the next release. > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#alv2-dep > 2. http://www.apache.org/dev/licensing-howto.html#mod-notice > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
