+1 (binding) Jarcec
> On Aug 14, 2017, at 7:45 AM, Atri Sharma <atri.j...@gmail.com> wrote: > > +1, except that I couldnt run RAT. > > On Mon, Aug 14, 2017 at 8:12 PM, Raymundo Panduro <rpand...@apache.org> wrote: >> Thanks John!! >> >> My comments below! >> >> >> On Sun, Aug 13, 2017 at 4:38 PM, John D. Ament <johndam...@apache.org> >> wrote: >> >>> +1 to release, however the following additions need to happen (as called >>> out in this thread): >>> >>> - Need a clear way to run RAT. >>> >> >> *We are working on this with automation script to make it easy to run and >> verfiy. * >> >> >> >>> - Need to clarify how to build each component ideally from the top level >>> >> >> *We will address this with dev team.* >> >> >> >>> - You must *not* create external websites that are referencing the release >>> of the project. The usage of NOLA Marketing needs to be dug into a bit >>> further. >>> >> >> *The NOLA Markegin page is just a test environment for the web page we >> understand not creating external websites. The Final update will be >> uploaded into http://spot.apache.org <http://spot.apache.org>, we will use >> a different approach for big changes on next release to avoid using NOLA >> Marketing servers.* >> >>> >>> John >>> >>> On Thu, Aug 10, 2017 at 12:35 PM Raymundo Panduro <raypand...@gmail.com> >>> wrote: >>> >>>> Hello IPMC members, >>>> >>>> Here are the instructions on how to build the release candidate once you >>>> download it. >>>> >>>> http://nolamarketing.com/client/apache-spot/download/ (If you don't see >>>> the >>>> *Validate Build* section use CTRL + F5 to refresh the page). >>>> >>>> >>>> Regarding the Licence comment, we updated the files in preparation for >>> next >>>> release: >>>> >>>> https://github.com/apache/incubator-spot/commit/ >>> ebb564ed058570d72e3b84fc418f7f87780efd44 >>>> >>>> If there are other comments please let us know. >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> *Raymundo Panduro* >>>> >>>> On Fri, Aug 4, 2017 at 6:37 PM, Justin Mclean <jus...@classsoftware.com> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> +1 binding >>>>> >>>>> I checked: >>>>> - name includes incubating >>>>> - hashes and signatures correct >>>>> - DISCLAIMER exists >>>>> - LICENSE is missing a few permissive licensed bundled items. Please >>> fix >>>>> for the next release >>>>> - NOTICE is good >>>>> - no unexpected binary files >>>>> - all source files have ASF headers >>>>> - Could compile from source (by running sbt assembly in spot_ml) >>>>> >>>>> Please include instruction on how to compile/build the release >>> candidate. >>>>> >>>>> With the license it maybe a good idea rather than referring to anther >>>>> license file it would be better to just include it if it is short OR >>> when >>>>> referencing to the other license file(s) at least mention what license >>> it >>>>> is. >>>>> >>>>> LICENSE is missing: >>>>> - MIT licensed code here [1] >>>>> - Public domain license material here [2][3] >>>>> >>>>> In the README the Maintainers section in the read me seems a little odd >>>> to >>>>> me. I would also put the dev and users mailing lists (which are >>> missing) >>>>> above the slack channel for community support. The link for JIRA also >>>> needs >>>>> fixing (should be just https://issues.apache.org/jira/projects/SPOT). >>>>> >>>>> Thanks, >>>>> Justin >>>>> >>>>> 1. spot-oa/ui/flow/js/lib/ChordMapper.js >>>>> 2. spot-oa/ui/flow/world-110m.json >>>>> 3. http://www.naturalearthdata.com/about/terms-of-use/ >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>>> >>>>> >>>> >>> > > > > -- > Regards, > > Atri > l'apprenant > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
