On Wed, Jun 28, 2017 at 3:26 PM Dan Kirkwood <dang...@gmail.com> wrote:
> Thanks John and Justin.. Eric's out for a few days, but I can work > on getting some of these things addressed. > > The build instructions will be put in place once the release is done > -- catch-22.. but I should be able to add a reference to the local > rst file as well. Would Jira issues for the copyright and build > instruction issues be sufficient? Or would you prefer to see another > RC to address those? > > The `./pkg` is the simplest way to build. If you give that a `-v`, > it will spill all the output to stdout so you can see where it's > erroring out. We are able to build it, so not sure where the issue > lies with building the traffic_portal. > Is there a log to look at the failure? Either way I'm fine with releasing as is, so +1. > > -dan > > On Tue, Jun 27, 2017 at 6:59 PM, John D. Ament <johndam...@apache.org> > wrote: > > On Tue, Jun 27, 2017 at 8:56 PM Justin Mclean <jus...@classsoftware.com> > > wrote: > > > >> Hi, > >> > >> +0 binding as I can’t build from source and no instructions provided. > >> > > > > I struggled with this a bit as well. The BUILD.md indicates: > > > > See the build instructions at ./docs/source/development/building.rst or > at > > > http://trafficcontrol.incubator.apache.org/docs/latest/development/building.html > > > > That URL doesn't work, but the rst file indicates running pkg does the > > build. > > > > However, when I run pkg, I get the following: > > > > ~/Desktop/apache-trafficcontrol-2.0.0-incubating > > ☺ ./pkg > > > > > > > > Building traffic_portal_build. > > Building traffic_router_build. > > Building traffic_monitor_build. > > Building source. > > Building traffic_ops_build. > > Building traffic_stats_build. > > Failed to build traffic_portal_build. > > > > > >> > >> I will change to +1 when I can compile/ you raise a JIRA to add > >> instructions on how to build. > >> > >> I checked: > >> - signatures and hashes good > >> - DISCLAIMER exists > >> - LICENSE good > >> - NOTICE OK . You can remove the information about the fonts in there > it’s > >> not needed. > >> - No unexpected binary files > >> - All source files have headers (there's a few script files and other > >> files that could also have headers) > >> - can't build from source > >> > >> when running the build.sh script it eventually fails with this error > >> > >> cp: ./build/*.spec: No such file or directory > >> Could not copy spec files: 1 > >> traffic_stats failed: > >> The following subdirectories had errors: > >> traffic_monitor > >> traffic_monitor_golang > >> traffic_ops > >> traffic_portal > >> traffic_router > >> traffic_stats > >> > >> Has perhaps something not been included in the release or is my > >> environment not set up correctly? > >> > >> It would be nice to include the build instructions in the build itself. > I > >> believe this has come up before. By providing a URL it means that the > >> content of that URL may change for future releases and people would be > >> unable to build this release. In fact the URL in the documentation is > >> incorrect [1] and currently 404s which is less than helpful. > >> > >> There a few file still copyright comcast I assume these need to be > >> removed? [2][3][4][5][6] > >> > >> Thanks, > >> Justin > >> > >> 1. > >> > http://trafficcontrol.incubator.apache.org/docs/latest/development/building.html > >> 2. > ./apache-trafficcontrol-2.0.0-incubating/traffic_ops/app/t/api/1.1/cdn.t > >> 3. > >> > ./apache-trafficcontrol-2.0.0-incubating/traffic_ops/client/delivery_service_resources.go > >> 4. > >> > ./apache-trafficcontrol-2.0.0-incubating/traffic_ops/install/lib/WebDep.pm > >> 5. ./apache-trafficcontrol-2.0.0-incubating/traffic_stats/vendor/ > >> github.com/jheitz200/test_helper/http.go > >> 6. ./apache-trafficcontrol-2.0.0-incubating/traffic_stats/vendor/ > >> github.com/jheitz200/test_helper/test.go > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
