+1 binding, though the license and notice have room for improvement signature and checksums are good tarball matches the git tag disclaimer is good builds from git tag unit tests pass overall the license and notice appear to reflect the contents of the source release, with the following notes that I'd like to see addressed in the future
for the source tarball: * htrace-c/pom.xml has the wrong license header * htrace-c/src/test/temp_dir.c appears to be an ASLv2 licensed file with "Copyright 2011-2012 the Redfish authors" and this isn't mentioned in the NOTICE * htrace-hbase/src/main/webapps/htrace/bootstrap-theme.min.css and htrace-hbase/src/main/webapps/htrace/bootstrap.min.css appear to have an older version of bootstrap (3.0.0 instead of 3.3.1) with ASLv2 license "Copyright 2013 Twitter, Inc" and this isn't mentioned in the NOTICE for the jars and war distributed in the maven repository: * distributed jars and wars should have their own LICENSE and NOTICE files reflecting what is included in them -- there are some BSD, MIT, and CDDL licensed classes included in the shaded jars that are not mentioned * htrace-zipkin-4.3.0-incubating.jar contains a confusing license file, META-INF/license/LICENSE.jboss-logging.txt, that states jboss logging is LGPL. jboss logging does not appear to be included in the jar, but I suspect the license file is present because jboss logging is an optional dependency of netty, which is included in the jar On Fri, 2 Jun 2017 15:11:19 -0500, Mike Drob <md...@apache.org> wrote: > Hi IPMC, > > Please consider the release of Apache HTrace 4.3.0 Incubating > > > > Project [VOTE]: > > https://lists.apache.org/thread.html/6e60ba2574a853da59c3a150f18cd9bbd52051785380a7cc837b583e@%3Cdev.htrace.apache.org%3E > > Project [RESULT][VOTE]: > > https://lists.apache.org/thread.html/fb2a68fcd9c80d9db4a483794112aecde486ca263384dec0bad38c34@%3Cdev.htrace.apache.org%3E > > Artifacts staged at: > > http://people.apache.org/~mdrob/htrace-4.3.0-incubating-rc3/ > > Staging maven repository at: > > https://repository.apache.org/content/repositories/orgapachehtrace-1029 > > Source tree: > > https://git-wip-us.apache.org/repos/asf?p=incubator-htrace.git;a=tree;h=2ca8767b38c83f0d2f46ce7f91373d9df69f7fb8;hb=a47398aea8d65fb544faba150beb49bb7654cb49 > > > Please download and evaluate the release candidate. > > This vote will remain open for minimum 5 days > > [ ] +1 Approve the release > > [ ] +0 No opinion > > [ ] -1 Do not approve the release because ... > > > Thanks, > > Mike
