+1, however there's a few issues with the LICENSE file: - Would be good to list out the locations of each file (or path to a group of files) (some have this, and others do not so its hard to follow) - There's errant /* .. */ around each license declaration, which should be removed. - Missing license bodies for FooTable v2, jQuery Clock Plugin,
Likewise, your NOTICE has copyright 2011-2017, however Airflow hasn't been incubating that long. If you like, you can give origination notices to the original creators here to specify the original copyright dates. I would challenge the podling to see if there's a way to simplify their LICENSE by instead using npm or some other javascript packaging tool to build a distribution, rather than shipping the dependencies in the source release, makes it much easier to use. As the podling matures, would be good to see information about the author switch from an individual to a community (in setup.cfg, its already in setup.py so may have been a miss) It would be great to see a binary distribution in the next vote to see how that may work, its not clear how to build it from this. Likewise, don't hesitate to clean up your old release artifacts, I downloaded the wrong artifact at first. John On Fri, May 5, 2017 at 4:44 PM Chris Riccomini <criccom...@apache.org> wrote: > Hello Incubator PMC’ers, > > The Apache Airflow community has voted and approved the proposal to release > Apache Airflow 1.8.1 (incubating) based on 1.8.1 Release Candidate 2. We > now kindly request the Incubator PMC members to review and vote on this > incubator release. If the vote is successful we will rename release > candidate 2 to final. > > Airflow is a platform to programmatically author, schedule and monitor > workflows. Use airflow to author workflows as directed acyclic graphs > (DAGs) of tasks. The airflow scheduler executes your tasks on an array of > workers while following the specified dependencies. Rich command line > utilities make performing complex surgeries on DAGs a snap. The rich user > interface makes it easy to visualize pipelines running in production, > monitor progress, and troubleshoot issues when needed. When workflows are > defined as code, they become more maintainable, versionable, testable, and > collaborative. > > The Apache Airflow-1.8.1-incubating release candidate is now available with > the following artifacts for a project vote: > > * [VOTE] Thread:* > > https://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201705.mbox/%3CCABYbY7eZk2SYHs3ni31h94uwwRdcn4dkJwumYtUMsfFLq-gwjg%40mail.gmail.com%3E > > *[RESULT] [VOTE] Thread:* > > https://mail-archives.apache.org/mod_mbox/incubator-airflow-dev/201705.mbox/%3CCABYbY7dBAnjcvb-w_4Hdy3ZUM3CGn6Y3eUvZctuFCfdAfPGAXQ%40mail.gmail.com%3E > > *The release candidate(s) to be voted on is available at:* > https://dist.apache.org/repos/dist/dev/incubator/airflow/ or > > https://dist.apache.org/repos/dist/dev/incubator/airflow/apache-airflow-1.8.1rc2+incubating.tar.gz > > *Git branch* > https://github.com/apache/incubator-airflow/tree/v1-8-test or > > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=tree;h=refs/heads/v1-8-stable;hb=refs/heads/v1-8-test > > *Git tag* > > https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;a=shortlog;h=af2d0b4b5cb1ef30a065b1af66f90a01a953e2be > > *PGP signature* > > https://dist.apache.org/repos/dist/dev/incubator/airflow/apache-airflow-1.8.1rc2+incubating.tar.gz.asc > > *MD5/SHA Hashes* > > https://dist.apache.org/repos/dist/dev/incubator/airflow/apache-airflow-1.8.1rc2+incubating.tar.gz.md5 > > https://dist.apache.org/repos/dist/dev/incubator/airflow/apache-airflow-1.8.1rc2+incubating.tar.gz.sha > > *Keys to verify the signature of the release artifacts are available at:* > https://dist.apache.org/repos/dist/release/incubator/airflow/ > > * RAT License checks* > > RAT is executed as part of the CI process (e.g. > https://travis-ci.org/apache/incubator-airflow/builds/226568140) but can > also be run manually by issuing “sh scripts/ci/check-license.sh” from the > top level. > > Source code is always included, i.e. there is no binary release. > Compilation and installation will happen by standard Python practices, e.g. > pip install <> or python setup.py install. > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > > Members please be sure to indicate "(Binding)" with your vote which will > help in tallying the vote(s). > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > *Here is my +1 (non-binding)* > > Cheers, > Bolke >
