Sorry but -1 due to misnamed package and binary content. - No "incubating" / "incubator" in package name - JAR files are present in the source release (gradle-wrapper.jar) - Ideally the expanded package would include "apache" in the folder, not a big deal. - DISCLAIMER present
Your NOTICE seems way too big. Do you actually bundle all of these dependencies? I can't find them if you do. Most of what's being called out in NOTICE should actually be in LICENSE. For instance, only Apache licensed code would normally call out NOTICE entries, and those entries are meant to be copied verbatim from the source package. In this case, fastjson is referenced (though I don't see it anywhere), but it has no NOTICE so nothing to declare. Meanwhile, your LICENSE is too short. Each project that you do bundle, if its not Apache licensed, you must copy its license text or provide a pointer to the license. We have a full guide on how to assemble these - http://www.apache.org/dev/licensing-howto.html - please reach out if you need help. The critical piece to fix is your package name. If you're re-rolling to fix that, I would recommend going through your NOTICE/LICENSE and see what does and doesn't belong. The second piece to fix is the JAR files. You must not include them (I've tried fighting the fight, and can't get anywhere on it - source releases are for source code only). John On Thu, Apr 20, 2017 at 4:11 AM sospartan <sospar...@apache.org> wrote: > Hi all, > I'll calling a vote for Weex-incubating 0.12.0-RC2 release. > > The PPMC vote for this release has passed: > > https://lists.apache.org/thread.html/d544a60a4038f9d053f7ea1eca0d162b9aef392551a02a0401041e8f@%3Cdev.weex.apache.org%3E > > The tag to be voted upon: > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git > ;a=shortlog;h=refs/tags/0.12.0-rc1 > > The commit hash: > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=commit;h= > 9ac0c82443e65b1c9d8a2714fea6b9a5b8af9907 > <https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git;a=commit;h=9ac0c82443e65b1c9d8a2714fea6b9a5b8af9907> > > The source tarball can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/weex/0.12.0-incubating/RC1/ > > The fingerprint of key to sign release artifacts: > 97B9 6598 A6A3 B63C 53BD 77E9 44C5 2286 22B9 7784 > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/dev/incubator/weex/KEYS > > Release note about this version: > https://issues.apache.org/jira/browse/WEEX-26 > > This vote will remain open for at least 72 hours. > Please vote on releasing this RC. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > -- > Best Regards! > ------------------------------ > > sospartan > https://weex-project.io >
