Thank you for reviewing Apache Quickstep 0.1.0 rc6 (incubating), everyone. With this I will close the vote.
+1 Julian (binding) Jignesh -1 Josh (binding) As we received one -1 binding vote, we will not release rc6. ___ The biggest issue seems to be our licensing checks. Now Fixed: - third_party/src/cpplint/lint_everything.py - ./parser/preprocessed/genfiles.sh - ./query_execution/ForemanDistributed.cpp (not sure about the origin of this and the following three) - ./query_execution/ForemanDistributed.hpp - ./query_execution/PolicyEnforcerDistributed.cpp - ./query_execution/PolicyEnforcerDistributed.hpp - We checked the KEYS in the svn repo against the signed artifact and the sig is fine, it was just my info which was old on the people.apache site -> now updated. - Our website has been updated to include the logo and reword "apache quickstep (incubating)". In progress: - We're reviewing what exactly goes in LICENSE/NOTICE files and will fix them for the next release. Not Fixed: - Julian turned us on to a previous issue with pre-processed parser files. It appears the content in /parser/preprocessed/ should be fine via discussion on https://issues.apache.org/jira/browse/LEGAL-291 Thank you, Marc On Thu, Mar 16, 2017 at 3:08 PM, Josh Elser <els...@apache.org> wrote: > -1 (binding) > > * xsums/sigs OK > > The key you provided isn't the one that was used to sign this release, > FYI. You have D280F52E up on your people space, but used 5A29899A to sign > this release. > > * Artifact starts with "apache-quickstep" and includes "incubating" > * DISCLAIMER present > * Missing LICENSE text for bundled software > * Can build from source > > cpplint and glog are bundled and licensed under 3-clause BSD, but this > text is not included in your LICENSE file. farmhash is MIT licensed and > also not listed in your LICENSE file. When you create these entries in > LICENSE, you can also move the copyright text from the NOTICE file and > place it in the LICENSE file as a convenience. > > It appears that you bundle Google Protobuf and that is 3-clause BSD and > also absent. Same for IWYU ("Include what you use"). > > * `./parser/preprocessed/*` seems to be licensed as GPLv3 from the header > which is a no-go. > > * Some missing/inaccurate license headers. Are these of Quickstep's > creation? Bundled from somewhere else? > - third_party/src/cpplint/lint_everything.py (I'm guessing this is of > your own creation, I don't see this in the cpplint github repo) > - ./parser/preprocessed/genfiles.sh > - ./query_execution/ForemanDistributed.cpp (not sure about the origin > of this and the following three) > - ./query_execution/ForemanDistributed.hpp > - ./query_execution/PolicyEnforcerDistributed.cpp > - ./query_execution/PolicyEnforcerDistributed.hpp > > gflags is listed in NOTICE but not bundled (at least at the noted > location). Strike this text or fix the location at which it is bundled. > > Aside: took a look at your website. A few comments: > > * ASF incubator text is there. Good work. > * If you could include the incubator logo, that would also be good (per > policy). > * Typically podlings refer to themselves as "Apache Quickstep > (incubating)" instead of "Apache (incubating) Quickstep" as in the header > in the landing page :) > > Pretty close, but just a couple of bad licensing things to clean up here. > Please feel free to ask if what I pointed out is unclear/wrong. > > - Josh > > > Marc Spehlmann wrote: > >> The Apache Incubator Quickstep community has approved a vote to release >> Quickstep-0.1.0 RC6. Quickstep is a high performance relational database >> system built from the ground up for modern hardware. >> >> This vote will stay open until Wednesday 18:00 cst. >> >> -Marc >> ___ >> The vote and results thread from dev: >> https://lists.apache.org/thread.html/4da9e32fc24d7fc24b91795 >> 0760b726734c7023aa92da4e7fa16db85@%3Cdev.quickstep.apache.org%3E >> >> https://lists.apache.org/thread.html/6c8bbfd15504e4ff6d12404 >> 3a6c19c5463769cf495d69e0ef7825085@%3Cdev.quickstep.apache.org%3E >> >> The commit to be voted upon: >> https://git-wip-us.apache.org/repos/asf?p=incubator-quickste >> p.git;a=commit;h=f8cf7fba51db3748c1c241c7e8880d499634213b >> >> The artifacts to be voted on are located here: >> https://dist.apache.org/repos/dist/dev/incubator/quickstep/0.1.0/RC6/ >> >> Release artifacts are signed with the following key: >> https://people.apache.org/keys/committer/spehl >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
