Alan, Per your suggestion (which I agree with), I will be pulling this release from IPMC release review consideration. We will be updating the Apache RAT pom.xml file to refine the exclusions of the "src/test" directory so this visibility of the jar files will be evident. Additionally, we will enhance our verification steps to include searching for "jar" files throughout the source tree.
Looking for ways to enhance the identification of release issues as early as possible, would you be willing to share the release review process you follow? Thanks, -=e On Thu, Feb 9, 2017 at 11:28 AM, Alan Gates <[email protected]> wrote: > Generally we don't want binary files in source releases, so unless there's > a very strong reason to continue with the release I'd say it's better to > respin it. > > Alan. > > > On Feb 9, 2017, at 11:15 AM, Ed Espino <[email protected]> wrote: > > > > Alan, > > > > Please, no need to apologize. We appreciate your review contributions > > immensely. I was just getting a bit anxious as this is my initial time > > being a release manager for an Apache project. > > > > Does the existence of the jar files warrant another release candidate or > > can we fix HAWQ-1319 in the next release? > > > > -=e > > > > On Thu, Feb 9, 2017 at 11:00 AM, Alan Gates <[email protected]> > wrote: > > > >> I responded on the thread. Sorry, I should have seen this sooner and > >> voted on it. > >> > >> Alan. > >> > >>> On Feb 9, 2017, at 10:48 AM, Ed Espino <[email protected]> wrote: > >>> > >>> Good catch Alan. I agree with you that the jar files should be > removed. I > >>> have created https://issues.apache.org/jira/browse/HAWQ-1319 to > address > >>> this issue. > >>> > >>> Regards, > >>> -=e > >>> > >>> On Thu, Feb 9, 2017 at 10:25 AM, Alan Gates <[email protected]> > >> wrote: > >>> > >>>> I checked the licenses, notice, disclaimer, and signatures. These all > >>>> look good. > >>>> > >>>> One question, there are a couple of jar files in a test directory, > >>>> ./src/test/feature/UDF/sql/PLJavaAdd.jar and > >> ./src/test/feature/UDF/sql/ > >>>> PLJavauAdd.jar > >>>> In general it's a bad idea to include binary files since users have a > >> hard > >>>> time verifying their contents. Are these necessary? Could they not > be > >>>> built as part of the build? > >>>> > >>>> Alan. > >>>> > >>>>> On Feb 7, 2017, at 11:33 PM, Ed Espino <[email protected]> wrote: > >>>>> > >>>>> Hello Incubator PMC (IPMC), > >>>>> > >>>>> The Apache HAWQ community has voted on and approved a proposal to > >>>>> release Apache HAWQ 2.1.0.0-incubating (source only release). > >>>>> > >>>>> We kindly request that the IPMC members review and vote on this > >>>>> incubator release. > >>>>> > >>>>> The PPMC VOTE thread is here: > >>>>> https://lists.apache.org/thread.html/ac664618426411fa2021b2b36b4ce4 > >>>> 2f9d5bc505a9aa8d901c14fbbd@%3Cdev.hawq.apache.org%3E > >>>>> > >>>>> The PPMC VOTE RESULT is here: > >>>>> https://lists.apache.org/thread.html/4463b3f7bee2d7e3e10e71fe01ce70 > >>>> 348bd23a493e00d08730343eea@%3Cdev.hawq.apache.org%3E > >>>>> > >>>>> All JIRAs completed for this release are tagged with: > >>>>> fixVersion = 2.1.0.0-incubating > >>>>> A complete JIRA list can be reviewed here: > >>>>> * > >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? > >>>> projectId=12318826&version=12338900 > >>>>> > >>>>> The tag to be voted on: 2.1.0.0-incubating-rc3 > >>>>> * > >>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-hawq. > >> git;a=commit;h= > >>>> 12c7df017551f1c3b0deb38c7243db3e018ef62c > >>>>> > >>>>> Git release branch: > >>>>> * > >>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-hawq. > >>>> git;a=shortlog;h=refs/heads/2.1.0.0-incubating > >>>>> > >>>>> Source release package: > >>>>> * > >>>>> https://dist.apache.org/repos/dist/dev/incubator/hawq/2.1.0. > >>>> 0-incubating.RC3/apache-hawq-src-2.1.0.0-incubating.tar.gz > >>>>> > >>>>> Source release verification: > >>>>> * PGP Signature: > >>>>> > >>>>> https://dist.apache.org/repos/dist/dev/incubator/hawq/2.1.0. > >>>> 0-incubating.RC3/apache-hawq-src-2.1.0.0-incubating.tar.gz.asc > >>>>> * SHA256/MD5 Hash: > >>>>> > >>>>> https://dist.apache.org/repos/dist/dev/incubator/hawq/2.1.0. > >>>> 0-incubating.RC3/apache-hawq-src-2.1.0.0-incubating.tar.gz.sha256 > >>>>> > >>>>> https://dist.apache.org/repos/dist/dev/incubator/hawq/2.1.0. > >>>> 0-incubating.RC3/apache-hawq-src-2.1.0.0-incubating.tar.gz.md5 > >>>>> > >>>>> Keys to verify the signature of the release artifact are available > at: > >>>>> * https://dist.apache.org/repos/dist/dev/incubator/hawq/KEYS > >>>>> > >>>>> The artifact(s) has been signed with Key ID: 57325522 (" > >>>> [email protected]") > >>>>> > >>>>> Build instructions are included in the project's wiki: > >>>>> https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install > >>>>> > >>>>> When voting, please list the actions taken to verify the release. To > >>>>> facilitate Apache license review and conformance, an Apache Release > >>>>> Audit Tool (RAT) pom.xml file is included in the source root > >>>>> directory. > >>>>> > >>>>> The vote will be open for at least 72 hours. > >>>>> > >>>>> Please vote: > >>>>> [ ] +1 Approve the release > >>>>> [ ] +0 no opinion > >>>>> [ ] -1 Don't approve the release (please provide specific comments) > >>>>> > >>>>> Thanks, > >>>>> -=ed espino > >>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> > >>> > >>> > >>> -- > >>> *Ed Espino* > >>> *[email protected] <[email protected]>* > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > > > -- > > *Ed Espino* > > *[email protected] <[email protected]>* > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- *Ed Espino* *[email protected] <[email protected]>*
