Hello, Thanks Jim. I hadn't realised that I needed to download the apache-rat jar (I got it from Maven https://mvnrepository.com/artifact/org.apache.rat/apache-rat/0.12). I also had to clone the impala repo from github to create the git archive since the archive available from https://dist.apache.org/repos/dist/dev/incubator/impala/2.8.0/RC1/ doesn't seem to have the .git directory needed. After doing this the rat check passed with an 'OK'.
So it is definitely a +1 (non-binding). Cheers, Ian On 16/01/17 21:14, Jim Apple wrote: > Thank you for taking the time to check the artifact and vote. > >> I didn't RAT check because I didn't have a rat.xml to use the script >> against and I wasn't sure how to create one. > bin/check-rat-report.py describes, on lines 28-30, how to run it, > including how to create rat.xml. > >> Also the build uses a lot of bandwidth and takes quite some time. Might >> be worth pointing that out. > Good point. bin/bootstrap_build.sh takes 30-45 minutes on an ec2 > c3xlarge instance, which voters can read about (in order to compare it > to their build machines) here: > https://aws.amazon.com/ec2/instance-types/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
signature.asc
Description: OpenPGP digital signature
