Hi, +1 binding
I can see that most items in the JIRA ticket have been fixed (ie adding jQuery) to LICENSE it’s just not been closed. I checked: - name contains incubating - disclaimer exists - signatures and hash correct - NOTICE good (but year needs updating) - LICENSE is good - Source files have ASF headers - No unexpected binary files - Can compile from source (although had some issues see below) BTW I could compile previously with "cd fineract-provider;gradle build” and didn’t need to stuff about with the wrapper. No sure if that is correct or not. You may want add this to the readme to save people from searching for the wrapper jar: curl https://repo.gradle.org/gradle/libs-releases-local/org/gradle/gradle-wrapper/2.10/gradle-wrapper-2.10.jar > fineract-provider/gradle/wrapper/gradle-wrapper-2.10.jar Or just run this (but think this only works on recent versions?) gradle wrapper --gradle-version 2.10 You may already be aware of this but you might also want to update the version of spring boot to get around this bug with gradle 3 [1]. I had to downgrade my version of gradle to compile. Thanks, Justin 1. https://discuss.gradle.org/t/bug-in-gradle-3-0-java-lang-unsupportedoperationexception/19332 --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
