Hi Justin, thank you for reviewing the release. 1) I would remove the list of software included in the binary release from the source release LICENSE file. It’s fine to have two different license files. The LICENSE may also be missing a license for jquery [1]? Nazeer: The existing JQuery license file suffice for v1.9.1, v1.10.2. I will add different license file for v1.7, v1.7.1 as these two are coming with different copyright notice. I will discuss with my mentors on having different license files for binary and source.
The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in the top level, however the LICENSE and NOTICE file is inside the war and look correct. Can you fix this in the next release please. Nazeer: Sure I will move them as suggested. On Tue, Dec 20, 2016 at 4:22 AM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 binding > > I checked: > - signatures and hashes correct > - incubating in release names > - DISCLAIMER exists in source > - LICENSE and NOTICE good > - All source files have ASF headers > - No unexpected binary files > - Can compile from source > > I would remove the list of software included in the binary release from > the source release LICENSE file. It’s fine to have two different license > files. The LICENSE may also be missing a license for jquery [1]? > > The convenience binary file is missing LICENSE, NOTICE and DISCLAIMER in > the top level, however the LICENSE and NOTICE file is inside the war and > look correct. Can you fix this in the next release please. > > Thanks, > Justin > > 1. ./docs/system-architecture/css/toc-0.1.2/example/jquery.js > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
