Good call on the "carbondata-parent" file name.
It came from Maven artifact id =)

- Henry

On Fri, Oct 7, 2016 at 1:40 PM, Julian Hyde <jh...@apache.org> wrote:

> +1 (binding)
>
> Checked LICENSE, NOTICE, DISCLAIMER, checksums, ran rat, checked for
> unexpected binaries.
>
> I was not able to build (not your fault - I did not have thrift
> installed and didn't have the time & patience to install it).
>
> Some notes:
> * It would be useful if source-release.zip contains a README (it
> contains README.md, but that has a different purpose)
> * README.md refers to "Apache CarbonData" but must say "Apache
> CarbonData (incubating)"; it must include an incubation disclaimer; it
> should not credit Huawei (or any corporate entity).
> * A more conventional name for the distro would be
> "apache-carbondata-0.1.1-incubating-src.zip" rather than
> "carbondata-parent-0.1.1-incubating-source-release.zip".
>
> Please consider fixing these before the next release (and in fact
> earlier for the issues with README.md).
>
> Julian
>
>
> On Fri, Oct 7, 2016 at 10:47 AM, Henry Saputra <henry.sapu...@gmail.com>
> wrote:
> > DISCLAIMER file exits
> > LICENSE file looks good
> > NOTICE file look good
> > Artifacts has incubating tag
> > No executables binaries in source artifacts
> > Can compile from source
> >
> > +1 (binding)
> >
> > - Henry
> >
> > On Wed, Oct 5, 2016 at 3:06 AM, Liang Big data <chenliang6...@gmail.com>
> > wrote:
> >
> >> Hi all,
> >>
> >> PPMC vote for the release Apache CarbonData 0.1.1-incubating has passed.
> >>
> >> Now, we kindly submit this release to the IPMC.
> >>
> >> Here's the PPMC vote thread for 0.1.1 release:
> >> https://lists.apache.org/thread.html/5b70a2eea0c0249d7947df4e3a789b
> >> 90867f3c0f4822f1f868ee926d@%3Cdev.carbondata.apache.org%3E
> >>
> >> The source distribution, with signatures is there:
> >> https://dist.apache.org/repos/dist/dev/incubator/carbondata/
> >> 0.1.1-incubating/
> >>
> >> The git tag is:
> >> https://git-wip-us.apache.org/repos/asf?p=incubator-
> >> carbondata.git;a=commit;h=7fa00c3618b7f92bf00c9836cd265e9d1343bcfb
> >>
> >> The artifacts have been signed with this key:
> >> https://dist.apache.org/repos/dist/dev/incubator/carbondata/KEYS
> >>
> >> Please vote to approve this release:
> >>
> >> [ ] +1 Approve the release
> >> [ ] -1 Don't approve the release (please provide specific comments)
> >>
> >> This vote will be open for at least 72 hours.
> >>
> >> Thanks !
> >> Regards
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>

Reply via email to