By the way, yes, the files were part of the software grant. We did
renaming and cleaning but we missed these ones.
Thanks again!
Regards
JB
On 08/23/2016 03:34 AM, Justin Mclean wrote:
Hi,
-1 binding until issues below discussed / resolved. I assume it’s probably OK
and just left over headers from the software grant and a couple of extra Apache
header that were added where they probably shouldn’t be.
I checked:
- incubating in name
- signature and hash good
- NOTICE good
- LICENSE fine but may be missing something?
- Several files have double headers which is unusual
- Looks to be one unexpected binary file in the source release [15]? Is this
file needed?
- Can compile from source
Several files include the below as well as an Apache ASF header, there's a bit
of a contradiction here. Were these files part of the original software grant?
If not how are these files licensed?
/**
* Copyright Notice
* =====================================
* This file contains proprietary information of
* Huawei Technologies India Pvt Ltd.
* Copying or reproduction without prior written approval is prohibited.
* Copyright (c) 1997
* =====================================
*/
This file [7] also has a similar issue copyright 2012.
These files [8][9][10][11][12] are copyright 2005 Bytecode Pty Ltd. Do they
come from openCSV? [13] If so why do these files also have an ASF header? [14]
Thanks,
Justin
1.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/DataPartitioner.java
2.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/CSVFilePartitioner.java
3.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/DefaultLoadBalancer.java
4.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/PartitionImpl.java
5.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/impl/QueryPartitionHelper.java
6.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/api/Partition.java
7. ./core/src/test/java/org/apache/carbondata/scan/QueryExecutor_UT.java
8.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVParser.java
9.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVReader.java
10.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/CSVWriter.java
11.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelper.java
12.
./integration/spark/src/main/java/org/apache/carbondata/spark/partition/reader/ResultSetHelperService.java
13. https://sourceforge.net/projects/opencsv/
14. http://www.apache.org/legal/src-headers.html#3party
15 ./core/src/test/resources/part-0-0-1466029397000.carbondata
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
