Hi,

+1 binding

I checked:
- file name contains incubating
- DISCLAIMER exits
- LICENSE and NOTICE correct
- All source files have headers
- No binary files in release
- Unable to build from source 

Other than the build issue also a very easy release to review.

I was unable to build from source on OSX even with:
 mvn -pl '!mnemonic-memory-services/mnemonic-nvml-vmem-service' clean package

But assuming it’s my setup.

Would be nice for the README could have slightly clearer instructions on how to 
build on different platforms.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to