Hi, Sorry -1 (binding) for possible inclusion of MPL licensed source code in the source release and uncertainty of licensing of files missing headers.
I checked: - incubating in name - signatures and hashes good - DISCLAIMER exists - LICENSE is missing a couple of things - NOTICE includes unnecessary copyright lines. NOTICE should be minimal [3] - Large a number of files are missing apache headers (i.e. .sh, .in, .c, .h, .hpp, .py. .cpp files) - No unexpected binaries - Can compile from source LICENSE is missing: - BSD license code in [2] - BSD licensed [4] - BSD licensed [5] - MIT licensed [6] - There are several areas where file are missing headers, it unclear if these are 3rd party files or Apache licensed file. This may effect LICENSE and NOTICE. There may be a more serious issue with this file [7] as it seems to be based on [8] and looks to be MPL licensed. MPL licensed source code cannot be used in a source release. [9] Not sure how this files are licensed [10][11][12] as they are missing headers. There a quite a number of other .c and .h files missing headers in the same directories as well. This could be as simple as missing headers or is it that they are not Apache licensed and 3rd party code? There are serval other places where this is also an issue e.g. [13][14][15][16][17] + others. if as noted in the pom.xml file this files are previous BSD licensed files from MADlib (and not 3rd party software) and part of the software grant then they should have Apache headers. I’m also not 100% what the contents of licenses/third_party/ has to do with the source release. There seems to be a couple of extra non bundled items in there and the items are not mentioned in LICENSE? Are these for a binary convenience release? Other very minor things: - best to use an apache email address for signing - best to use short form of the license and mention the license name in LICENSE [1] Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps 2. ./src/ports/postgres/cmake/FindPostgreSQL.cmake 3. http://www.apache.org/dev/licensing-howto.html#mod-notice 4. ./cmake/UseLATEX.cmake 5. ./cmake/FindArmadillo.cmake 6. ./src/madpack/yaml/* 7. i.//doc/etc/navtree_hack.js 8. https://github.com/bravegag/eigen-magma/blob/master/doc/eigen_navtree_hacks.js 9. http://www.apache.org/legal/resolved.html#category-b 10. ./methods/array_ops/src/pg_gp/array_ops.c 11. ./methods/cart/src/pg_gp/dt.c 12. ./methods/kmeans/src/pg_gp/kmeans.c 13. ./src/modules/assoc_rules/* 14. ./src/modules/convex/* 15. ./src/modules/elastic_net/* 16. ./src/ports/postgres/dbconnector/* 17. ./src/utils/* --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
